From a8499a26685788281d2df6b5ed3d6e307303aa14 Mon Sep 17 00:00:00 2001 From: Joey de Vries Date: Wed, 22 Apr 2020 12:58:38 +0200 Subject: [PATCH] Fix infinite loop error w/ unsigned ints used on decrementing for counters. --- src/6.pbr/1.1.lighting/lighting.cpp | 2 +- src/6.pbr/1.2.lighting_textured/lighting_textured.cpp | 2 +- .../ibl_irradiance_conversion.cpp | 2 +- src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp | 2 +- src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp | 2 +- src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/6.pbr/1.1.lighting/lighting.cpp b/src/6.pbr/1.1.lighting/lighting.cpp index 17c27fb..bd1138b 100644 --- a/src/6.pbr/1.1.lighting/lighting.cpp +++ b/src/6.pbr/1.1.lighting/lighting.cpp @@ -289,7 +289,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x); diff --git a/src/6.pbr/1.2.lighting_textured/lighting_textured.cpp b/src/6.pbr/1.2.lighting_textured/lighting_textured.cpp index ce1a211..c10e9bf 100644 --- a/src/6.pbr/1.2.lighting_textured/lighting_textured.cpp +++ b/src/6.pbr/1.2.lighting_textured/lighting_textured.cpp @@ -300,7 +300,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x); diff --git a/src/6.pbr/2.1.1.ibl_irradiance_conversion/ibl_irradiance_conversion.cpp b/src/6.pbr/2.1.1.ibl_irradiance_conversion/ibl_irradiance_conversion.cpp index 4db3d23..b95dc73 100644 --- a/src/6.pbr/2.1.1.ibl_irradiance_conversion/ibl_irradiance_conversion.cpp +++ b/src/6.pbr/2.1.1.ibl_irradiance_conversion/ibl_irradiance_conversion.cpp @@ -405,7 +405,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x); diff --git a/src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp b/src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp index f9b6a5b..2b7f1cf 100644 --- a/src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp +++ b/src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp @@ -445,7 +445,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x); diff --git a/src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp b/src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp index da8556e..a3e84f1 100644 --- a/src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp +++ b/src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp @@ -543,7 +543,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x); diff --git a/src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp b/src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp index d406592..9750ec9 100644 --- a/src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp +++ b/src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp @@ -643,7 +643,7 @@ void renderSphere() } else { - for (unsigned int x = X_SEGMENTS; x >= 0; --x) + for (int x = X_SEGMENTS; x >= 0; --x) { indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);