lenn/LearnOpenGL
1
0
Fork 0
mirror of https://github.com/JoeyDeVries/LearnOpenGL.git synced 2026-01-30 20:13:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

fixed compiler warnings reported by gcc/clang

Browse Source 
* changed some catch blocks to use exception references instead of value types
 * fixed missing use of SCR_WIDTH/SCR_HEIGHT for glfwCreateWindow
 * fixed implicit numeric type casts regarding signedness
 * removed unused variables

Signed-off-by: Toni Uhlig <matzeton@googlemail.com>
This commit is contained in:
Toni Uhlig
2020-03-18 18:34:17 +01:00
parent 3fe2e0ad4a
commit dcdf94fce7
14 changed files with 32 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
includes/learnopengl/shader.h
View File

@@ -53,7 +53,7 @@ public:
geometryCode = gShaderStream.str();
}
}
catch (std::ifstream::failure e)
catch (std::ifstream::failure& e)
{
std::cout << "ERROR::SHADER::FILE_NOT_SUCCESFULLY_READ" << std::endl;
}
@@ -188,4 +188,4 @@ private:
}
}
};
#endif
#endif

4
includes/learnopengl/shader_m.h
View File

@@ -41,7 +41,7 @@ public:
vertexCode = vShaderStream.str();
fragmentCode = fShaderStream.str();
}
catch (std::ifstream::failure e)
catch (std::ifstream::failure& e)
{
std::cout << "ERROR::SHADER::FILE_NOT_SUCCESFULLY_READ" << std::endl;
}
@@ -162,4 +162,4 @@ private:
}
}
};
#endif
#endif

4
includes/learnopengl/shader_s.h
View File

@@ -40,7 +40,7 @@ public:
vertexCode = vShaderStream.str();
fragmentCode = fShaderStream.str();
}
catch (std::ifstream::failure e)
catch (std::ifstream::failure& e)
{
std::cout << "ERROR::SHADER::FILE_NOT_SUCCESFULLY_READ" << std::endl;
}
@@ -118,4 +118,4 @@ private:
}
}
};
#endif
#endif