|
@@ -119,22 +119,28 @@ jobs:
|
|
# Breaking PRs don't need to follow semver since they are breaking changes
|
|
# Breaking PRs don't need to follow semver since they are breaking changes
|
|
# However, this means we won't attempt to backport them, so you should be careful about using this label, as it will
|
|
# However, this means we won't attempt to backport them, so you should be careful about using this label, as it will
|
|
# likely make future backporting difficult
|
|
# likely make future backporting difficult
|
|
- semver:
|
|
|
|
- if: github.event.pull_request.draft == false && !contains(github.event.pull_request.labels.*.name, 'breaking')
|
|
|
|
- name: Semver Check
|
|
|
|
- runs-on: ubuntu-latest
|
|
|
|
- steps:
|
|
|
|
- - uses: actions/checkout@v4
|
|
|
|
- - uses: dtolnay/rust-toolchain@stable
|
|
|
|
- - uses: Swatinem/rust-cache@v2
|
|
|
|
- with:
|
|
|
|
- cache-all-crates: "true"
|
|
|
|
- save-if: ${{ github.ref == 'refs/heads/main' }}
|
|
|
|
- - name: Check semver
|
|
|
|
- uses: obi1kenobi/cargo-semver-checks-action@v2
|
|
|
|
- with:
|
|
|
|
- manifest-path: ./Cargo.toml
|
|
|
|
- exclude: "dioxus-cli, dioxus-ext"
|
|
|
|
|
|
+ #
|
|
|
|
+ # todo: fix this so even if breaking changes have been merged, the fix can be backported
|
|
|
|
+ #
|
|
|
|
+ # This will stop working once the first breaking change has been merged, so we should really try to just backport the fix
|
|
|
|
+ # and *then* run the semver checks. Basically "would backporting this PR cause a breaking change on stable?"
|
|
|
|
+ #
|
|
|
|
+ # semver:
|
|
|
|
+ # if: github.event.pull_request.draft == false && !contains(github.event.pull_request.labels.*.name, 'breaking')
|
|
|
|
+ # name: Semver Check
|
|
|
|
+ # runs-on: ubuntu-latest
|
|
|
|
+ # steps:
|
|
|
|
+ # - uses: actions/checkout@v4
|
|
|
|
+ # - uses: dtolnay/rust-toolchain@stable
|
|
|
|
+ # - uses: Swatinem/rust-cache@v2
|
|
|
|
+ # with:
|
|
|
|
+ # cache-all-crates: "true"
|
|
|
|
+ # save-if: ${{ github.ref == 'refs/heads/main' }}
|
|
|
|
+ # - name: Check semver
|
|
|
|
+ # uses: obi1kenobi/cargo-semver-checks-action@v2
|
|
|
|
+ # with:
|
|
|
|
+ # manifest-path: ./Cargo.toml
|
|
|
|
+ # exclude: "dioxus-cli, dioxus-ext"
|
|
|
|
|
|
playwright:
|
|
playwright:
|
|
if: github.event.pull_request.draft == false
|
|
if: github.event.pull_request.draft == false
|