소스 검색

Rename --debug to --force-debug and improve docs

Evan Almloff 1 년 전
부모
커밋
d88a662877
3개의 변경된 파일9개의 추가작업 그리고 8개의 파일을 삭제
  1. 2 1
      packages/cli/src/cli/build.rs
  2. 5 5
      packages/cli/src/cli/cfg.rs
  3. 2 2
      packages/cli/src/server/fullstack/mod.rs

+ 2 - 1
packages/cli/src/cli/build.rs

@@ -78,7 +78,8 @@ impl Build {
                         }
                         None => desktop_config.features = Some(vec![desktop_feature]),
                     };
-                    let _gaurd = FullstackServerEnvGuard::new(self.build.debug, self.build.release);
+                    let _gaurd =
+                        FullstackServerEnvGuard::new(self.build.force_debug, self.build.release);
                     crate::builder::build_desktop(&desktop_config, false, self.build.skip_assets)?;
                 }
             }

+ 5 - 5
packages/cli/src/cli/cfg.rs

@@ -15,10 +15,10 @@ pub struct ConfigOptsBuild {
     #[serde(default)]
     pub release: bool,
 
-    /// Build with all debug info [default: false]
+    /// This flag only applies to fullstack builds. By default fullstack builds will run with something in between debug and release mode. This flag will force the build to run in debug mode. [default: false]
     #[clap(long)]
     #[serde(default)]
-    pub debug: bool,
+    pub force_debug: bool,
 
     // Use verbose output [default: false]
     #[clap(long)]
@@ -68,7 +68,7 @@ impl From<ConfigOptsServe> for ConfigOptsBuild {
             client_feature: serve.client_feature,
             server_feature: serve.server_feature,
             skip_assets: serve.skip_assets,
-            debug: serve.debug,
+            force_debug: serve.force_debug,
         }
     }
 }
@@ -98,10 +98,10 @@ pub struct ConfigOptsServe {
     #[serde(default)]
     pub release: bool,
 
-    /// Build with all debug info [default: false]
+    /// This flag only applies to fullstack builds. By default fullstack builds will run with something in between debug and release mode. This flag will force the build to run in debug mode. [default: false]
     #[clap(long)]
     #[serde(default)]
-    pub debug: bool,
+    pub force_debug: bool,
 
     // Use verbose output [default: false]
     #[clap(long)]

+ 2 - 2
packages/cli/src/server/fullstack/mod.rs

@@ -66,7 +66,7 @@ impl Platform for FullstackPlatform {
                 }
                 None => desktop_config.features = Some(vec![desktop_feature]),
             };
-            let _gaurd = FullstackServerEnvGuard::new(self.serve.debug, self.serve.release);
+            let _gaurd = FullstackServerEnvGuard::new(self.serve.force_debug, self.serve.release);
             self.desktop.rebuild(&desktop_config)
         };
         thread_handle
@@ -101,7 +101,7 @@ pub(crate) struct FullstackWebEnvGuard {
 impl FullstackWebEnvGuard {
     pub fn new(serve: &ConfigOptsBuild) -> Self {
         Self {
-            old_rustflags: (!serve.debug).then(|| {
+            old_rustflags: (!serve.force_debug).then(|| {
                 let old_rustflags = std::env::var("RUSTFLAGS").unwrap_or_default();
                 let debug_assertions = if serve.release {
                     ""