diffing.rs 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716
  1. //! Diffing Tests
  2. //!
  3. //! These tests only verify that the diffing algorithm works properly for single components.
  4. //!
  5. //! It does not validated that component lifecycles work properly. This is done in another test file.
  6. use dioxus::{nodes::VSuspended, prelude::*, DomEdit, TestDom};
  7. use dioxus_core as dioxus;
  8. use dioxus_core_macro::*;
  9. use dioxus_html as dioxus_elements;
  10. mod test_logging;
  11. fn new_dom() -> TestDom {
  12. const IS_LOGGING_ENABLED: bool = false;
  13. test_logging::set_up_logging(IS_LOGGING_ENABLED);
  14. TestDom::new()
  15. }
  16. use DomEdit::*;
  17. /// Should push the text node onto the stack and modify it
  18. #[test]
  19. fn html_and_rsx_generate_the_same_output() {
  20. let dom = new_dom();
  21. let (create, change) = dom.lazy_diff(
  22. rsx! ( div { "Hello world" } ),
  23. rsx! ( div { "Goodbye world" } ),
  24. );
  25. assert_eq!(
  26. create.edits,
  27. [
  28. CreateElement { id: 0, tag: "div" },
  29. CreateTextNode {
  30. id: 1,
  31. text: "Hello world"
  32. },
  33. AppendChildren { many: 1 },
  34. AppendChildren { many: 1 },
  35. ]
  36. );
  37. assert_eq!(
  38. change.edits,
  39. [
  40. PushRoot { id: 1 },
  41. SetText {
  42. text: "Goodbye world"
  43. },
  44. PopRoot
  45. ]
  46. );
  47. }
  48. /// Should result in 3 elements on the stack
  49. #[test]
  50. fn fragments_create_properly() {
  51. let dom = new_dom();
  52. let create = dom.create(rsx! {
  53. div { "Hello a" }
  54. div { "Hello b" }
  55. div { "Hello c" }
  56. });
  57. assert_eq!(
  58. create.edits,
  59. [
  60. CreateElement { id: 0, tag: "div" },
  61. CreateTextNode {
  62. id: 1,
  63. text: "Hello a"
  64. },
  65. AppendChildren { many: 1 },
  66. CreateElement { id: 2, tag: "div" },
  67. CreateTextNode {
  68. id: 3,
  69. text: "Hello b"
  70. },
  71. AppendChildren { many: 1 },
  72. CreateElement { id: 4, tag: "div" },
  73. CreateTextNode {
  74. id: 5,
  75. text: "Hello c"
  76. },
  77. AppendChildren { many: 1 },
  78. AppendChildren { many: 3 },
  79. ]
  80. );
  81. }
  82. /// Should result in the creation of an anchor (placeholder) and then a replacewith
  83. #[test]
  84. fn empty_fragments_create_anchors() {
  85. let dom = new_dom();
  86. let left = rsx!({ (0..0).map(|_f| rsx! { div {}}) });
  87. let right = rsx!({ (0..1).map(|_f| rsx! { div {}}) });
  88. let (create, change) = dom.lazy_diff(left, right);
  89. assert_eq!(
  90. create.edits,
  91. [CreatePlaceholder { id: 0 }, AppendChildren { many: 1 }]
  92. );
  93. assert_eq!(
  94. change.edits,
  95. [
  96. CreateElement { id: 1, tag: "div" },
  97. ReplaceWith { m: 1, root: 0 }
  98. ]
  99. );
  100. }
  101. /// Should result in the creation of an anchor (placeholder) and then a replacewith m=5
  102. #[test]
  103. fn empty_fragments_create_many_anchors() {
  104. let dom = new_dom();
  105. let left = rsx!({ (0..0).map(|_f| rsx! { div {}}) });
  106. let right = rsx!({ (0..5).map(|_f| rsx! { div {}}) });
  107. let (create, change) = dom.lazy_diff(left, right);
  108. assert_eq!(
  109. create.edits,
  110. [CreatePlaceholder { id: 0 }, AppendChildren { many: 1 }]
  111. );
  112. assert_eq!(
  113. change.edits,
  114. [
  115. CreateElement { id: 1, tag: "div" },
  116. CreateElement { id: 2, tag: "div" },
  117. CreateElement { id: 3, tag: "div" },
  118. CreateElement { id: 4, tag: "div" },
  119. CreateElement { id: 5, tag: "div" },
  120. ReplaceWith { m: 5, root: 0 }
  121. ]
  122. );
  123. }
  124. /// Should result in the creation of an anchor (placeholder) and then a replacewith
  125. /// Includes child nodes inside the fragment
  126. #[test]
  127. fn empty_fragments_create_anchors_with_many_children() {
  128. let dom = new_dom();
  129. let left = rsx!({ (0..0).map(|_| rsx! { div {} }) });
  130. let right = rsx!({
  131. (0..3).map(|f| {
  132. rsx! { div { "hello: {f}" }}
  133. })
  134. });
  135. let (create, change) = dom.lazy_diff(left, right);
  136. assert_eq!(
  137. create.edits,
  138. [CreatePlaceholder { id: 0 }, AppendChildren { many: 1 }]
  139. );
  140. assert_eq!(
  141. change.edits,
  142. [
  143. CreateElement { id: 1, tag: "div" },
  144. CreateTextNode {
  145. text: "hello: 0",
  146. id: 2
  147. },
  148. AppendChildren { many: 1 },
  149. CreateElement { id: 3, tag: "div" },
  150. CreateTextNode {
  151. text: "hello: 1",
  152. id: 4
  153. },
  154. AppendChildren { many: 1 },
  155. CreateElement { id: 5, tag: "div" },
  156. CreateTextNode {
  157. text: "hello: 2",
  158. id: 6
  159. },
  160. AppendChildren { many: 1 },
  161. ReplaceWith { m: 3, root: 0 }
  162. ]
  163. );
  164. }
  165. /// Should result in every node being pushed and then replaced with an anchor
  166. #[test]
  167. fn many_items_become_fragment() {
  168. let dom = new_dom();
  169. let left = rsx!({
  170. (0..2).map(|_| {
  171. rsx! { div { "hello" }}
  172. })
  173. });
  174. let right = rsx!({ (0..0).map(|_| rsx! { div {} }) });
  175. let (create, change) = dom.lazy_diff(left, right);
  176. assert_eq!(
  177. create.edits,
  178. [
  179. CreateElement { id: 0, tag: "div" },
  180. CreateTextNode {
  181. text: "hello",
  182. id: 1
  183. },
  184. AppendChildren { many: 1 },
  185. CreateElement { id: 2, tag: "div" },
  186. CreateTextNode {
  187. text: "hello",
  188. id: 3
  189. },
  190. AppendChildren { many: 1 },
  191. AppendChildren { many: 2 },
  192. ]
  193. );
  194. // hmmmmmmmmm worried about reusing IDs that we shouldnt be
  195. assert_eq!(
  196. change.edits,
  197. [
  198. Remove { root: 2 },
  199. CreatePlaceholder { id: 4 },
  200. ReplaceWith { root: 0, m: 1 },
  201. ]
  202. );
  203. }
  204. /// Should result in no edits
  205. #[test]
  206. fn two_equal_fragments_are_equal() {
  207. let dom = new_dom();
  208. let left = rsx!({
  209. (0..2).map(|_| {
  210. rsx! { div { "hello" }}
  211. })
  212. });
  213. let right = rsx!({
  214. (0..2).map(|_| {
  215. rsx! { div { "hello" }}
  216. })
  217. });
  218. let (_create, change) = dom.lazy_diff(left, right);
  219. assert!(change.edits.is_empty());
  220. }
  221. /// Should result the creation of more nodes appended after the old last node
  222. #[test]
  223. fn two_fragments_with_differrent_elements_are_differet() {
  224. let dom = new_dom();
  225. let left = rsx!(
  226. { (0..2).map(|_| rsx! { div { }} ) }
  227. p {}
  228. );
  229. let right = rsx!(
  230. { (0..5).map(|_| rsx! (h1 { }) ) }
  231. p {}
  232. );
  233. let (_create, changes) = dom.lazy_diff(left, right);
  234. log::debug!("{:#?}", &changes);
  235. assert_eq!(
  236. changes.edits,
  237. [
  238. // create the new h1s
  239. CreateElement { tag: "h1", id: 3 },
  240. CreateElement { tag: "h1", id: 4 },
  241. CreateElement { tag: "h1", id: 5 },
  242. InsertAfter { root: 1, n: 3 },
  243. // replace the divs with new h1s
  244. CreateElement { tag: "h1", id: 6 },
  245. ReplaceWith { root: 0, m: 1 },
  246. CreateElement { tag: "h1", id: 7 },
  247. ReplaceWith { root: 1, m: 1 },
  248. ]
  249. );
  250. }
  251. /// Should result in multiple nodes destroyed - with changes to the first nodes
  252. #[test]
  253. fn two_fragments_with_differrent_elements_are_differet_shorter() {
  254. let dom = new_dom();
  255. let left = rsx!(
  256. {(0..5).map(|f| {rsx! { div { }}})}
  257. p {}
  258. );
  259. let right = rsx!(
  260. {(0..2).map(|f| {rsx! { h1 { }}})}
  261. p {}
  262. );
  263. let (create, change) = dom.lazy_diff(left, right);
  264. assert_eq!(
  265. create.edits,
  266. [
  267. CreateElement { id: 0, tag: "div" },
  268. CreateElement { id: 1, tag: "div" },
  269. CreateElement { id: 2, tag: "div" },
  270. CreateElement { id: 3, tag: "div" },
  271. CreateElement { id: 4, tag: "div" },
  272. CreateElement { id: 5, tag: "p" },
  273. AppendChildren { many: 6 },
  274. ]
  275. );
  276. assert_eq!(
  277. change.edits,
  278. [
  279. Remove { root: 2 },
  280. Remove { root: 3 },
  281. Remove { root: 4 },
  282. CreateElement { id: 6, tag: "h1" },
  283. ReplaceWith { root: 0, m: 1 },
  284. CreateElement { id: 7, tag: "h1" },
  285. ReplaceWith { root: 1, m: 1 },
  286. ]
  287. );
  288. }
  289. /// Should result in multiple nodes destroyed - with no changes
  290. #[test]
  291. fn two_fragments_with_same_elements_are_differet() {
  292. let dom = new_dom();
  293. let left = rsx!(
  294. {(0..2).map(|f| {rsx! { div { }}})}
  295. p {}
  296. );
  297. let right = rsx!(
  298. {(0..5).map(|f| {rsx! { div { }}})}
  299. p {}
  300. );
  301. let (create, change) = dom.lazy_diff(left, right);
  302. assert_eq!(
  303. create.edits,
  304. [
  305. CreateElement { id: 0, tag: "div" },
  306. CreateElement { id: 1, tag: "div" },
  307. CreateElement { id: 2, tag: "p" },
  308. AppendChildren { many: 3 },
  309. ]
  310. );
  311. assert_eq!(
  312. change.edits,
  313. [
  314. CreateElement { id: 3, tag: "div" },
  315. CreateElement { id: 4, tag: "div" },
  316. CreateElement { id: 5, tag: "div" },
  317. InsertAfter { root: 1, n: 3 },
  318. ]
  319. );
  320. }
  321. /// should result in the removal of elements
  322. #[test]
  323. fn keyed_diffing_order() {
  324. let dom = new_dom();
  325. let left = rsx!(
  326. {(0..5).map(|f| {rsx! { div { key: "{f}" }}})}
  327. p {"e"}
  328. );
  329. let right = rsx!(
  330. {(0..2).map(|f| {rsx! { div { key: "{f}" }}})}
  331. p {"e"}
  332. );
  333. let (create, change) = dom.lazy_diff(left, right);
  334. assert_eq!(
  335. change.edits,
  336. [Remove { root: 2 }, Remove { root: 3 }, Remove { root: 4 },]
  337. );
  338. }
  339. /// Should result in moves, but not removals or additions
  340. #[test]
  341. fn keyed_diffing_out_of_order() {
  342. let dom = new_dom();
  343. let left = rsx!({
  344. [0, 1, 2, 3, /**/ 4, 5, 6, /**/ 7, 8, 9].iter().map(|f| {
  345. rsx! { div { key: "{f}" }}
  346. })
  347. });
  348. let right = rsx!({
  349. [0, 1, 2, 3, /**/ 6, 4, 5, /**/ 7, 8, 9].iter().map(|f| {
  350. rsx! { div { key: "{f}" }}
  351. })
  352. });
  353. let (_, changes) = dom.lazy_diff(left, right);
  354. log::debug!("{:?}", &changes);
  355. assert_eq!(
  356. changes.edits,
  357. [PushRoot { id: 6 }, InsertBefore { root: 4, n: 1 }]
  358. );
  359. }
  360. /// Should result in moves only
  361. #[test]
  362. fn keyed_diffing_out_of_order_adds() {
  363. let dom = new_dom();
  364. let left = rsx!({
  365. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  366. rsx! { div { key: "{f}" }}
  367. })
  368. });
  369. let right = rsx!({
  370. [/**/ 8, 7, 4, 5, 6 /**/].iter().map(|f| {
  371. rsx! { div { key: "{f}" }}
  372. })
  373. });
  374. let (_, change) = dom.lazy_diff(left, right);
  375. assert_eq!(
  376. change.edits,
  377. [
  378. PushRoot { id: 4 },
  379. PushRoot { id: 3 },
  380. InsertBefore { n: 2, root: 0 }
  381. ]
  382. );
  383. }
  384. /// Should result in moves onl
  385. #[test]
  386. fn keyed_diffing_out_of_order_adds_2() {
  387. let dom = new_dom();
  388. let left = rsx!({
  389. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  390. rsx! { div { key: "{f}" }}
  391. })
  392. });
  393. let right = rsx!({
  394. [/**/ 7, 8, 4, 5, 6 /**/].iter().map(|f| {
  395. rsx! { div { key: "{f}" }}
  396. })
  397. });
  398. let (_, change) = dom.lazy_diff(left, right);
  399. assert_eq!(
  400. change.edits,
  401. [
  402. PushRoot { id: 3 },
  403. PushRoot { id: 4 },
  404. InsertBefore { n: 2, root: 0 }
  405. ]
  406. );
  407. }
  408. /// Should result in moves onl
  409. #[test]
  410. fn keyed_diffing_out_of_order_adds_3() {
  411. let dom = new_dom();
  412. let left = rsx!({
  413. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  414. rsx! { div { key: "{f}" }}
  415. })
  416. });
  417. let right = rsx!({
  418. [/**/ 4, 8, 7, 5, 6 /**/].iter().map(|f| {
  419. rsx! { div { key: "{f}" }}
  420. })
  421. });
  422. let (_, change) = dom.lazy_diff(left, right);
  423. assert_eq!(
  424. change.edits,
  425. [
  426. PushRoot { id: 4 },
  427. PushRoot { id: 3 },
  428. InsertBefore { n: 2, root: 1 }
  429. ]
  430. );
  431. }
  432. /// Should result in moves onl
  433. #[test]
  434. fn keyed_diffing_out_of_order_adds_4() {
  435. let dom = new_dom();
  436. let left = rsx!({
  437. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  438. rsx! { div { key: "{f}" }}
  439. })
  440. });
  441. let right = rsx!({
  442. [/**/ 4, 5, 8, 7, 6 /**/].iter().map(|f| {
  443. rsx! { div { key: "{f}" }}
  444. })
  445. });
  446. let (_, change) = dom.lazy_diff(left, right);
  447. assert_eq!(
  448. change.edits,
  449. [
  450. PushRoot { id: 4 },
  451. PushRoot { id: 3 },
  452. InsertBefore { n: 2, root: 2 }
  453. ]
  454. );
  455. }
  456. /// Should result in moves onl
  457. #[test]
  458. fn keyed_diffing_out_of_order_adds_5() {
  459. let dom = new_dom();
  460. let left = rsx!({
  461. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  462. rsx! { div { key: "{f}" }}
  463. })
  464. });
  465. let right = rsx!({
  466. [/**/ 4, 5, 6, 8, 7 /**/].iter().map(|f| {
  467. rsx! { div { key: "{f}" }}
  468. })
  469. });
  470. let (_, change) = dom.lazy_diff(left, right);
  471. assert_eq!(
  472. change.edits,
  473. [PushRoot { id: 4 }, InsertBefore { n: 1, root: 3 }]
  474. );
  475. }
  476. #[test]
  477. fn keyed_diffing_additions() {
  478. let dom = new_dom();
  479. let left = rsx!({
  480. [/**/ 4, 5, 6, 7, 8 /**/].iter().map(|f| {
  481. rsx! { div { key: "{f}" }}
  482. })
  483. });
  484. let right = rsx!({
  485. [/**/ 4, 5, 6, 7, 8, 9, 10 /**/].iter().map(|f| {
  486. rsx! { div { key: "{f}" }}
  487. })
  488. });
  489. let (_, change) = dom.lazy_diff(left, right);
  490. assert_eq!(
  491. change.edits,
  492. [
  493. CreateElement { id: 5, tag: "div" },
  494. CreateElement { id: 6, tag: "div" },
  495. InsertAfter { n: 2, root: 4 }
  496. ]
  497. );
  498. }
  499. #[test]
  500. fn keyed_diffing_additions_and_moves_on_ends() {
  501. let dom = new_dom();
  502. let left = rsx!({
  503. [/**/ 4, 5, 6, 7 /**/].iter().map(|f| {
  504. rsx! { div { key: "{f}" }}
  505. })
  506. });
  507. let right = rsx!({
  508. [/**/ 7, 4, 5, 6, 11, 12 /**/].iter().map(|f| {
  509. rsx! { div { key: "{f}" }}
  510. })
  511. });
  512. let (_, change) = dom.lazy_diff(left, right);
  513. log::debug!("{:?}", change);
  514. assert_eq!(
  515. change.edits,
  516. [
  517. // create 11, 12
  518. CreateElement { tag: "div", id: 4 },
  519. CreateElement { tag: "div", id: 5 },
  520. InsertAfter { root: 2, n: 2 },
  521. // move 7 to the front
  522. PushRoot { id: 3 },
  523. InsertBefore { root: 0, n: 1 }
  524. ]
  525. );
  526. }
  527. #[test]
  528. fn keyed_diffing_additions_and_moves_in_middle() {
  529. let dom = new_dom();
  530. let left = rsx!({
  531. [/**/ 4, 5, 6, 7 /**/].iter().map(|f| {
  532. rsx! { div { key: "{f}" }}
  533. })
  534. });
  535. let right = rsx!({
  536. [/**/ 7, 4, 13, 17, 5, 11, 12, 6 /**/].iter().map(|f| {
  537. rsx! { div { key: "{f}" }}
  538. })
  539. });
  540. // LIS: 4, 5, 6
  541. let (_, change) = dom.lazy_diff(left, right);
  542. log::debug!("{:#?}", change);
  543. assert_eq!(
  544. change.edits,
  545. [
  546. // create 13, 17
  547. CreateElement { tag: "div", id: 4 },
  548. CreateElement { tag: "div", id: 5 },
  549. InsertBefore { root: 1, n: 2 },
  550. // create 11, 12
  551. CreateElement { tag: "div", id: 6 },
  552. CreateElement { tag: "div", id: 7 },
  553. InsertBefore { root: 2, n: 2 },
  554. // move 7
  555. PushRoot { id: 3 },
  556. InsertBefore { root: 0, n: 1 }
  557. ]
  558. );
  559. }
  560. #[test]
  561. fn controlled_keyed_diffing_out_of_order() {
  562. let dom = new_dom();
  563. let left = rsx!({
  564. [4, 5, 6, 7].iter().map(|f| {
  565. rsx! { div { key: "{f}" }}
  566. })
  567. });
  568. let right = rsx!({
  569. [0, 5, 9, 6, 4].iter().map(|f| {
  570. rsx! { div { key: "{f}" }}
  571. })
  572. });
  573. // LIS: 5, 6
  574. let (_, changes) = dom.lazy_diff(left, right);
  575. log::debug!("{:#?}", &changes);
  576. assert_eq!(
  577. changes.edits,
  578. [
  579. // move 4 to after 6
  580. PushRoot { id: 0 },
  581. InsertAfter { n: 1, root: 2 },
  582. // remove 7
  583. // create 9 and insert before 6
  584. CreateElement { id: 4, tag: "div" },
  585. InsertBefore { n: 1, root: 2 },
  586. // create 0 and insert before 5
  587. CreateElement { id: 5, tag: "div" },
  588. InsertBefore { n: 1, root: 1 },
  589. ]
  590. );
  591. }
  592. #[test]
  593. fn controlled_keyed_diffing_out_of_order_max_test() {
  594. let dom = new_dom();
  595. let left = rsx!({
  596. [0, 1, 2, 3, 4].iter().map(|f| {
  597. rsx! { div { key: "{f}" }}
  598. })
  599. });
  600. let right = rsx!({
  601. [3, 0, 1, 10, 2].iter().map(|f| {
  602. rsx! { div { key: "{f}" }}
  603. })
  604. });
  605. let (_, changes) = dom.lazy_diff(left, right);
  606. log::debug!("{:#?}", &changes);
  607. assert_eq!(
  608. changes.edits,
  609. [
  610. CreateElement { id: 5, tag: "div" },
  611. InsertBefore { n: 1, root: 2 },
  612. PushRoot { id: 3 },
  613. InsertBefore { n: 1, root: 0 },
  614. ]
  615. );
  616. }
  617. #[test]
  618. fn suspense() {
  619. let dom = new_dom();
  620. let edits = dom.create(LazyNodes::new(|f| {
  621. use std::cell::{Cell, RefCell};
  622. VNode::Suspended(f.bump().alloc(VSuspended {
  623. task_id: 0,
  624. callback: RefCell::new(None),
  625. dom_id: Cell::new(None),
  626. }))
  627. }));
  628. assert_eq!(
  629. edits.edits,
  630. [CreatePlaceholder { id: 0 }, AppendChildren { many: 1 }]
  631. );
  632. }