str_format_test.cc 26 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774
  1. // Copyright 2020 The Abseil Authors.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // https://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. #include "absl/strings/str_format.h"
  15. #include <cstdarg>
  16. #include <cstdint>
  17. #include <cstdio>
  18. #include <string>
  19. #include "gmock/gmock.h"
  20. #include "gtest/gtest.h"
  21. #include "absl/strings/cord.h"
  22. #include "absl/strings/str_cat.h"
  23. #include "absl/strings/string_view.h"
  24. namespace absl {
  25. ABSL_NAMESPACE_BEGIN
  26. namespace {
  27. using str_format_internal::FormatArgImpl;
  28. using FormatEntryPointTest = ::testing::Test;
  29. TEST_F(FormatEntryPointTest, Format) {
  30. std::string sink;
  31. EXPECT_TRUE(Format(&sink, "A format %d", 123));
  32. EXPECT_EQ("A format 123", sink);
  33. sink.clear();
  34. ParsedFormat<'d'> pc("A format %d");
  35. EXPECT_TRUE(Format(&sink, pc, 123));
  36. EXPECT_EQ("A format 123", sink);
  37. }
  38. TEST_F(FormatEntryPointTest, UntypedFormat) {
  39. constexpr const char* formats[] = {
  40. "",
  41. "a",
  42. "%80d",
  43. #if !defined(_MSC_VER) && !defined(__ANDROID__) && !defined(__native_client__)
  44. // MSVC, NaCL and Android don't support positional syntax.
  45. "complicated multipart %% %1$d format %1$0999d",
  46. #endif // _MSC_VER
  47. };
  48. for (const char* fmt : formats) {
  49. std::string actual;
  50. int i = 123;
  51. FormatArgImpl arg_123(i);
  52. absl::Span<const FormatArgImpl> args(&arg_123, 1);
  53. UntypedFormatSpec format(fmt);
  54. EXPECT_TRUE(FormatUntyped(&actual, format, args));
  55. char buf[4096]{};
  56. snprintf(buf, sizeof(buf), fmt, 123);
  57. EXPECT_EQ(
  58. str_format_internal::FormatPack(
  59. str_format_internal::UntypedFormatSpecImpl::Extract(format), args),
  60. buf);
  61. EXPECT_EQ(actual, buf);
  62. }
  63. // The internal version works with a preparsed format.
  64. ParsedFormat<'d'> pc("A format %d");
  65. int i = 345;
  66. FormatArg arg(i);
  67. std::string out;
  68. EXPECT_TRUE(str_format_internal::FormatUntyped(
  69. &out, str_format_internal::UntypedFormatSpecImpl(&pc), {&arg, 1}));
  70. EXPECT_EQ("A format 345", out);
  71. }
  72. TEST_F(FormatEntryPointTest, StringFormat) {
  73. EXPECT_EQ("123", StrFormat("%d", 123));
  74. constexpr absl::string_view view("=%d=", 4);
  75. EXPECT_EQ("=123=", StrFormat(view, 123));
  76. }
  77. TEST_F(FormatEntryPointTest, AppendFormat) {
  78. std::string s;
  79. std::string& r = StrAppendFormat(&s, "%d", 123);
  80. EXPECT_EQ(&s, &r); // should be same object
  81. EXPECT_EQ("123", r);
  82. }
  83. TEST_F(FormatEntryPointTest, AppendFormatFail) {
  84. std::string s = "orig";
  85. UntypedFormatSpec format(" more %d");
  86. FormatArgImpl arg("not an int");
  87. EXPECT_EQ("orig",
  88. str_format_internal::AppendPack(
  89. &s, str_format_internal::UntypedFormatSpecImpl::Extract(format),
  90. {&arg, 1}));
  91. }
  92. TEST_F(FormatEntryPointTest, ManyArgs) {
  93. EXPECT_EQ("24", StrFormat("%24$d", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
  94. 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24));
  95. EXPECT_EQ("60", StrFormat("%60$d", 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13,
  96. 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26,
  97. 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39,
  98. 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52,
  99. 53, 54, 55, 56, 57, 58, 59, 60));
  100. }
  101. TEST_F(FormatEntryPointTest, Preparsed) {
  102. ParsedFormat<'d'> pc("%d");
  103. EXPECT_EQ("123", StrFormat(pc, 123));
  104. // rvalue ok?
  105. EXPECT_EQ("123", StrFormat(ParsedFormat<'d'>("%d"), 123));
  106. constexpr absl::string_view view("=%d=", 4);
  107. EXPECT_EQ("=123=", StrFormat(ParsedFormat<'d'>(view), 123));
  108. }
  109. TEST_F(FormatEntryPointTest, FormatCountCapture) {
  110. int n = 0;
  111. EXPECT_EQ("", StrFormat("%n", FormatCountCapture(&n)));
  112. EXPECT_EQ(0, n);
  113. EXPECT_EQ("123", StrFormat("%d%n", 123, FormatCountCapture(&n)));
  114. EXPECT_EQ(3, n);
  115. }
  116. TEST_F(FormatEntryPointTest, FormatCountCaptureWrongType) {
  117. // Should reject int*.
  118. int n = 0;
  119. UntypedFormatSpec format("%d%n");
  120. int i = 123, *ip = &n;
  121. FormatArgImpl args[2] = {FormatArgImpl(i), FormatArgImpl(ip)};
  122. EXPECT_EQ("", str_format_internal::FormatPack(
  123. str_format_internal::UntypedFormatSpecImpl::Extract(format),
  124. absl::MakeSpan(args)));
  125. }
  126. TEST_F(FormatEntryPointTest, FormatCountCaptureMultiple) {
  127. int n1 = 0;
  128. int n2 = 0;
  129. EXPECT_EQ(" 1 2",
  130. StrFormat("%5d%n%10d%n", 1, FormatCountCapture(&n1), 2,
  131. FormatCountCapture(&n2)));
  132. EXPECT_EQ(5, n1);
  133. EXPECT_EQ(15, n2);
  134. }
  135. TEST_F(FormatEntryPointTest, FormatCountCaptureExample) {
  136. int n;
  137. std::string s;
  138. StrAppendFormat(&s, "%s: %n%s\n", "(1,1)", FormatCountCapture(&n), "(1,2)");
  139. StrAppendFormat(&s, "%*s%s\n", n, "", "(2,2)");
  140. EXPECT_EQ(7, n);
  141. EXPECT_EQ(
  142. "(1,1): (1,2)\n"
  143. " (2,2)\n",
  144. s);
  145. }
  146. TEST_F(FormatEntryPointTest, Stream) {
  147. const std::string formats[] = {
  148. "",
  149. "a",
  150. "%80d",
  151. "%d %u %c %s %f %g",
  152. #if !defined(_MSC_VER) && !defined(__ANDROID__) && !defined(__native_client__)
  153. // MSVC, NaCL and Android don't support positional syntax.
  154. "complicated multipart %% %1$d format %1$080d",
  155. #endif // _MSC_VER
  156. };
  157. std::string buf(4096, '\0');
  158. for (const auto& fmt : formats) {
  159. const auto parsed =
  160. ParsedFormat<'d', 'u', 'c', 's', 'f', 'g'>::NewAllowIgnored(fmt);
  161. std::ostringstream oss;
  162. oss << StreamFormat(*parsed, 123, 3, 49, "multistreaming!!!", 1.01, 1.01);
  163. int fmt_result = snprintf(&*buf.begin(), buf.size(), fmt.c_str(), //
  164. 123, 3, 49, "multistreaming!!!", 1.01, 1.01);
  165. ASSERT_TRUE(oss) << fmt;
  166. ASSERT_TRUE(fmt_result >= 0 && static_cast<size_t>(fmt_result) < buf.size())
  167. << fmt_result;
  168. EXPECT_EQ(buf.c_str(), oss.str());
  169. }
  170. }
  171. TEST_F(FormatEntryPointTest, StreamOk) {
  172. std::ostringstream oss;
  173. oss << StreamFormat("hello %d", 123);
  174. EXPECT_EQ("hello 123", oss.str());
  175. EXPECT_TRUE(oss.good());
  176. }
  177. TEST_F(FormatEntryPointTest, StreamFail) {
  178. std::ostringstream oss;
  179. UntypedFormatSpec format("hello %d");
  180. FormatArgImpl arg("non-numeric");
  181. oss << str_format_internal::Streamable(
  182. str_format_internal::UntypedFormatSpecImpl::Extract(format), {&arg, 1});
  183. EXPECT_EQ("hello ", oss.str()); // partial write
  184. EXPECT_TRUE(oss.fail());
  185. }
  186. std::string WithSnprintf(const char* fmt, ...) {
  187. std::string buf;
  188. buf.resize(128);
  189. va_list va;
  190. va_start(va, fmt);
  191. int r = vsnprintf(&*buf.begin(), buf.size(), fmt, va);
  192. va_end(va);
  193. EXPECT_GE(r, 0);
  194. EXPECT_LT(r, buf.size());
  195. buf.resize(r);
  196. return buf;
  197. }
  198. TEST_F(FormatEntryPointTest, FloatPrecisionArg) {
  199. // Test that positional parameters for width and precision
  200. // are indexed to precede the value.
  201. // Also sanity check the same formats against snprintf.
  202. EXPECT_EQ("0.1", StrFormat("%.1f", 0.1));
  203. EXPECT_EQ("0.1", WithSnprintf("%.1f", 0.1));
  204. EXPECT_EQ(" 0.1", StrFormat("%*.1f", 5, 0.1));
  205. EXPECT_EQ(" 0.1", WithSnprintf("%*.1f", 5, 0.1));
  206. EXPECT_EQ("0.1", StrFormat("%.*f", 1, 0.1));
  207. EXPECT_EQ("0.1", WithSnprintf("%.*f", 1, 0.1));
  208. EXPECT_EQ(" 0.1", StrFormat("%*.*f", 5, 1, 0.1));
  209. EXPECT_EQ(" 0.1", WithSnprintf("%*.*f", 5, 1, 0.1));
  210. }
  211. namespace streamed_test {
  212. struct X {};
  213. std::ostream& operator<<(std::ostream& os, const X&) {
  214. return os << "X";
  215. }
  216. } // streamed_test
  217. TEST_F(FormatEntryPointTest, FormatStreamed) {
  218. EXPECT_EQ("123", StrFormat("%s", FormatStreamed(123)));
  219. EXPECT_EQ(" 123", StrFormat("%5s", FormatStreamed(123)));
  220. EXPECT_EQ("123 ", StrFormat("%-5s", FormatStreamed(123)));
  221. EXPECT_EQ("X", StrFormat("%s", FormatStreamed(streamed_test::X())));
  222. EXPECT_EQ("123", StrFormat("%s", FormatStreamed(StreamFormat("%d", 123))));
  223. }
  224. // Helper class that creates a temporary file and exposes a FILE* to it.
  225. // It will close the file on destruction.
  226. class TempFile {
  227. public:
  228. TempFile() : file_(std::tmpfile()) {}
  229. ~TempFile() { std::fclose(file_); }
  230. std::FILE* file() const { return file_; }
  231. // Read the file into a string.
  232. std::string ReadFile() {
  233. std::fseek(file_, 0, SEEK_END);
  234. int size = std::ftell(file_);
  235. EXPECT_GT(size, 0);
  236. std::rewind(file_);
  237. std::string str(2 * size, ' ');
  238. int read_bytes = std::fread(&str[0], 1, str.size(), file_);
  239. EXPECT_EQ(read_bytes, size);
  240. str.resize(read_bytes);
  241. EXPECT_TRUE(std::feof(file_));
  242. return str;
  243. }
  244. private:
  245. std::FILE* file_;
  246. };
  247. TEST_F(FormatEntryPointTest, FPrintF) {
  248. TempFile tmp;
  249. int result =
  250. FPrintF(tmp.file(), "STRING: %s NUMBER: %010d", std::string("ABC"), -19);
  251. EXPECT_EQ(result, 30);
  252. EXPECT_EQ(tmp.ReadFile(), "STRING: ABC NUMBER: -000000019");
  253. }
  254. TEST_F(FormatEntryPointTest, FPrintFError) {
  255. errno = 0;
  256. int result = FPrintF(stdin, "ABC");
  257. EXPECT_LT(result, 0);
  258. EXPECT_EQ(errno, EBADF);
  259. }
  260. #ifdef __GLIBC__
  261. TEST_F(FormatEntryPointTest, FprintfTooLarge) {
  262. std::FILE* f = std::fopen("/dev/null", "w");
  263. int width = 2000000000;
  264. errno = 0;
  265. int result = FPrintF(f, "%*d %*d", width, 0, width, 0);
  266. EXPECT_LT(result, 0);
  267. EXPECT_EQ(errno, EFBIG);
  268. std::fclose(f);
  269. }
  270. TEST_F(FormatEntryPointTest, PrintF) {
  271. int stdout_tmp = dup(STDOUT_FILENO);
  272. TempFile tmp;
  273. std::fflush(stdout);
  274. dup2(fileno(tmp.file()), STDOUT_FILENO);
  275. int result = PrintF("STRING: %s NUMBER: %010d", std::string("ABC"), -19);
  276. std::fflush(stdout);
  277. dup2(stdout_tmp, STDOUT_FILENO);
  278. close(stdout_tmp);
  279. EXPECT_EQ(result, 30);
  280. EXPECT_EQ(tmp.ReadFile(), "STRING: ABC NUMBER: -000000019");
  281. }
  282. #endif // __GLIBC__
  283. TEST_F(FormatEntryPointTest, SNPrintF) {
  284. char buffer[16];
  285. int result =
  286. SNPrintF(buffer, sizeof(buffer), "STRING: %s", std::string("ABC"));
  287. EXPECT_EQ(result, 11);
  288. EXPECT_EQ(std::string(buffer), "STRING: ABC");
  289. result = SNPrintF(buffer, sizeof(buffer), "NUMBER: %d", 123456);
  290. EXPECT_EQ(result, 14);
  291. EXPECT_EQ(std::string(buffer), "NUMBER: 123456");
  292. result = SNPrintF(buffer, sizeof(buffer), "NUMBER: %d", 1234567);
  293. EXPECT_EQ(result, 15);
  294. EXPECT_EQ(std::string(buffer), "NUMBER: 1234567");
  295. result = SNPrintF(buffer, sizeof(buffer), "NUMBER: %d", 12345678);
  296. EXPECT_EQ(result, 16);
  297. EXPECT_EQ(std::string(buffer), "NUMBER: 1234567");
  298. result = SNPrintF(buffer, sizeof(buffer), "NUMBER: %d", 123456789);
  299. EXPECT_EQ(result, 17);
  300. EXPECT_EQ(std::string(buffer), "NUMBER: 1234567");
  301. result = SNPrintF(nullptr, 0, "Just checking the %s of the output.", "size");
  302. EXPECT_EQ(result, 37);
  303. }
  304. TEST(StrFormat, BehavesAsDocumented) {
  305. std::string s = absl::StrFormat("%s, %d!", "Hello", 123);
  306. EXPECT_EQ("Hello, 123!", s);
  307. // The format of a replacement is
  308. // '%'[position][flags][width['.'precision]][length_modifier][format]
  309. EXPECT_EQ(absl::StrFormat("%1$+3.2Lf", 1.1), "+1.10");
  310. // Text conversion:
  311. // "c" - Character. Eg: 'a' -> "A", 20 -> " "
  312. EXPECT_EQ(StrFormat("%c", 'a'), "a");
  313. EXPECT_EQ(StrFormat("%c", 0x20), " ");
  314. // Formats char and integral types: int, long, uint64_t, etc.
  315. EXPECT_EQ(StrFormat("%c", int{'a'}), "a");
  316. EXPECT_EQ(StrFormat("%c", long{'a'}), "a"); // NOLINT
  317. EXPECT_EQ(StrFormat("%c", uint64_t{'a'}), "a");
  318. // "s" - string Eg: "C" -> "C", std::string("C++") -> "C++"
  319. // Formats std::string, char*, string_view, and Cord.
  320. EXPECT_EQ(StrFormat("%s", "C"), "C");
  321. EXPECT_EQ(StrFormat("%s", std::string("C++")), "C++");
  322. EXPECT_EQ(StrFormat("%s", string_view("view")), "view");
  323. EXPECT_EQ(StrFormat("%s", absl::Cord("cord")), "cord");
  324. // Integral Conversion
  325. // These format integral types: char, int, long, uint64_t, etc.
  326. EXPECT_EQ(StrFormat("%d", char{10}), "10");
  327. EXPECT_EQ(StrFormat("%d", int{10}), "10");
  328. EXPECT_EQ(StrFormat("%d", long{10}), "10"); // NOLINT
  329. EXPECT_EQ(StrFormat("%d", uint64_t{10}), "10");
  330. // d,i - signed decimal Eg: -10 -> "-10"
  331. EXPECT_EQ(StrFormat("%d", -10), "-10");
  332. EXPECT_EQ(StrFormat("%i", -10), "-10");
  333. // o - octal Eg: 10 -> "12"
  334. EXPECT_EQ(StrFormat("%o", 10), "12");
  335. // u - unsigned decimal Eg: 10 -> "10"
  336. EXPECT_EQ(StrFormat("%u", 10), "10");
  337. // x/X - lower,upper case hex Eg: 10 -> "a"/"A"
  338. EXPECT_EQ(StrFormat("%x", 10), "a");
  339. EXPECT_EQ(StrFormat("%X", 10), "A");
  340. // Floating-point, with upper/lower-case output.
  341. // These format floating points types: float, double, long double, etc.
  342. EXPECT_EQ(StrFormat("%.1f", float{1}), "1.0");
  343. EXPECT_EQ(StrFormat("%.1f", double{1}), "1.0");
  344. const long double long_double = 1.0;
  345. EXPECT_EQ(StrFormat("%.1f", long_double), "1.0");
  346. // These also format integral types: char, int, long, uint64_t, etc.:
  347. EXPECT_EQ(StrFormat("%.1f", char{1}), "1.0");
  348. EXPECT_EQ(StrFormat("%.1f", int{1}), "1.0");
  349. EXPECT_EQ(StrFormat("%.1f", long{1}), "1.0"); // NOLINT
  350. EXPECT_EQ(StrFormat("%.1f", uint64_t{1}), "1.0");
  351. // f/F - decimal. Eg: 123456789 -> "123456789.000000"
  352. EXPECT_EQ(StrFormat("%f", 123456789), "123456789.000000");
  353. EXPECT_EQ(StrFormat("%F", 123456789), "123456789.000000");
  354. // e/E - exponentiated Eg: .01 -> "1.00000e-2"/"1.00000E-2"
  355. EXPECT_EQ(StrFormat("%e", .01), "1.000000e-02");
  356. EXPECT_EQ(StrFormat("%E", .01), "1.000000E-02");
  357. // g/G - exponentiate to fit Eg: .01 -> "0.01", 1e10 ->"1e+10"/"1E+10"
  358. EXPECT_EQ(StrFormat("%g", .01), "0.01");
  359. EXPECT_EQ(StrFormat("%g", 1e10), "1e+10");
  360. EXPECT_EQ(StrFormat("%G", 1e10), "1E+10");
  361. // a/A - lower,upper case hex Eg: -3.0 -> "-0x1.8p+1"/"-0X1.8P+1"
  362. // On Android platform <=21, there is a regression in hexfloat formatting.
  363. #if !defined(__ANDROID_API__) || __ANDROID_API__ > 21
  364. EXPECT_EQ(StrFormat("%.1a", -3.0), "-0x1.8p+1"); // .1 to fix MSVC output
  365. EXPECT_EQ(StrFormat("%.1A", -3.0), "-0X1.8P+1"); // .1 to fix MSVC output
  366. #endif
  367. // Other conversion
  368. int64_t value = 0x7ffdeb4;
  369. auto ptr_value = static_cast<uintptr_t>(value);
  370. const int& something = *reinterpret_cast<const int*>(ptr_value);
  371. EXPECT_EQ(StrFormat("%p", &something), StrFormat("0x%x", ptr_value));
  372. // Output widths are supported, with optional flags.
  373. EXPECT_EQ(StrFormat("%3d", 1), " 1");
  374. EXPECT_EQ(StrFormat("%3d", 123456), "123456");
  375. EXPECT_EQ(StrFormat("%06.2f", 1.234), "001.23");
  376. EXPECT_EQ(StrFormat("%+d", 1), "+1");
  377. EXPECT_EQ(StrFormat("% d", 1), " 1");
  378. EXPECT_EQ(StrFormat("%-4d", -1), "-1 ");
  379. EXPECT_EQ(StrFormat("%#o", 10), "012");
  380. EXPECT_EQ(StrFormat("%#x", 15), "0xf");
  381. EXPECT_EQ(StrFormat("%04d", 8), "0008");
  382. // Posix positional substitution.
  383. EXPECT_EQ(absl::StrFormat("%2$s, %3$s, %1$s!", "vici", "veni", "vidi"),
  384. "veni, vidi, vici!");
  385. // Length modifiers are ignored.
  386. EXPECT_EQ(StrFormat("%hhd", int{1}), "1");
  387. EXPECT_EQ(StrFormat("%hd", int{1}), "1");
  388. EXPECT_EQ(StrFormat("%ld", int{1}), "1");
  389. EXPECT_EQ(StrFormat("%lld", int{1}), "1");
  390. EXPECT_EQ(StrFormat("%Ld", int{1}), "1");
  391. EXPECT_EQ(StrFormat("%jd", int{1}), "1");
  392. EXPECT_EQ(StrFormat("%zd", int{1}), "1");
  393. EXPECT_EQ(StrFormat("%td", int{1}), "1");
  394. EXPECT_EQ(StrFormat("%qd", int{1}), "1");
  395. }
  396. using str_format_internal::ExtendedParsedFormat;
  397. using str_format_internal::ParsedFormatBase;
  398. struct SummarizeConsumer {
  399. std::string* out;
  400. explicit SummarizeConsumer(std::string* out) : out(out) {}
  401. bool Append(string_view s) {
  402. *out += "[" + std::string(s) + "]";
  403. return true;
  404. }
  405. bool ConvertOne(const str_format_internal::UnboundConversion& conv,
  406. string_view s) {
  407. *out += "{";
  408. *out += std::string(s);
  409. *out += ":";
  410. *out += std::to_string(conv.arg_position) + "$";
  411. if (conv.width.is_from_arg()) {
  412. *out += std::to_string(conv.width.get_from_arg()) + "$*";
  413. }
  414. if (conv.precision.is_from_arg()) {
  415. *out += "." + std::to_string(conv.precision.get_from_arg()) + "$*";
  416. }
  417. *out += str_format_internal::FormatConversionCharToChar(conv.conv);
  418. *out += "}";
  419. return true;
  420. }
  421. };
  422. std::string SummarizeParsedFormat(const ParsedFormatBase& pc) {
  423. std::string out;
  424. if (!pc.ProcessFormat(SummarizeConsumer(&out))) out += "!";
  425. return out;
  426. }
  427. using ParsedFormatTest = ::testing::Test;
  428. TEST_F(ParsedFormatTest, SimpleChecked) {
  429. EXPECT_EQ("[ABC]{d:1$d}[DEF]",
  430. SummarizeParsedFormat(ParsedFormat<'d'>("ABC%dDEF")));
  431. EXPECT_EQ("{s:1$s}[FFF]{d:2$d}[ZZZ]{f:3$f}",
  432. SummarizeParsedFormat(ParsedFormat<'s', 'd', 'f'>("%sFFF%dZZZ%f")));
  433. EXPECT_EQ("{s:1$s}[ ]{.*d:3$.2$*d}",
  434. SummarizeParsedFormat(ParsedFormat<'s', '*', 'd'>("%s %.*d")));
  435. }
  436. TEST_F(ParsedFormatTest, SimpleUncheckedCorrect) {
  437. auto f = ParsedFormat<'d'>::New("ABC%dDEF");
  438. ASSERT_TRUE(f);
  439. EXPECT_EQ("[ABC]{d:1$d}[DEF]", SummarizeParsedFormat(*f));
  440. std::string format = "%sFFF%dZZZ%f";
  441. auto f2 = ParsedFormat<'s', 'd', 'f'>::New(format);
  442. ASSERT_TRUE(f2);
  443. EXPECT_EQ("{s:1$s}[FFF]{d:2$d}[ZZZ]{f:3$f}", SummarizeParsedFormat(*f2));
  444. f2 = ParsedFormat<'s', 'd', 'f'>::New("%s %d %f");
  445. ASSERT_TRUE(f2);
  446. EXPECT_EQ("{s:1$s}[ ]{d:2$d}[ ]{f:3$f}", SummarizeParsedFormat(*f2));
  447. auto star = ParsedFormat<'*', 'd'>::New("%*d");
  448. ASSERT_TRUE(star);
  449. EXPECT_EQ("{*d:2$1$*d}", SummarizeParsedFormat(*star));
  450. auto dollar = ParsedFormat<'d', 's'>::New("%2$s %1$d");
  451. ASSERT_TRUE(dollar);
  452. EXPECT_EQ("{2$s:2$s}[ ]{1$d:1$d}", SummarizeParsedFormat(*dollar));
  453. // with reuse
  454. dollar = ParsedFormat<'d', 's'>::New("%2$s %1$d %1$d");
  455. ASSERT_TRUE(dollar);
  456. EXPECT_EQ("{2$s:2$s}[ ]{1$d:1$d}[ ]{1$d:1$d}",
  457. SummarizeParsedFormat(*dollar));
  458. }
  459. TEST_F(ParsedFormatTest, SimpleUncheckedIgnoredArgs) {
  460. EXPECT_FALSE((ParsedFormat<'d', 's'>::New("ABC")));
  461. EXPECT_FALSE((ParsedFormat<'d', 's'>::New("%dABC")));
  462. EXPECT_FALSE((ParsedFormat<'d', 's'>::New("ABC%2$s")));
  463. auto f = ParsedFormat<'d', 's'>::NewAllowIgnored("ABC");
  464. ASSERT_TRUE(f);
  465. EXPECT_EQ("[ABC]", SummarizeParsedFormat(*f));
  466. f = ParsedFormat<'d', 's'>::NewAllowIgnored("%dABC");
  467. ASSERT_TRUE(f);
  468. EXPECT_EQ("{d:1$d}[ABC]", SummarizeParsedFormat(*f));
  469. f = ParsedFormat<'d', 's'>::NewAllowIgnored("ABC%2$s");
  470. ASSERT_TRUE(f);
  471. EXPECT_EQ("[ABC]{2$s:2$s}", SummarizeParsedFormat(*f));
  472. }
  473. TEST_F(ParsedFormatTest, SimpleUncheckedUnsupported) {
  474. EXPECT_FALSE(ParsedFormat<'d'>::New("%1$d %1$x"));
  475. EXPECT_FALSE(ParsedFormat<'x'>::New("%1$d %1$x"));
  476. }
  477. TEST_F(ParsedFormatTest, SimpleUncheckedIncorrect) {
  478. EXPECT_FALSE(ParsedFormat<'d'>::New(""));
  479. EXPECT_FALSE(ParsedFormat<'d'>::New("ABC%dDEF%d"));
  480. std::string format = "%sFFF%dZZZ%f";
  481. EXPECT_FALSE((ParsedFormat<'s', 'd', 'g'>::New(format)));
  482. }
  483. #if defined(__cpp_nontype_template_parameter_auto)
  484. template <auto T>
  485. std::true_type IsValidParsedFormatArgTest(ParsedFormat<T>*);
  486. template <auto T>
  487. std::false_type IsValidParsedFormatArgTest(...);
  488. template <auto T>
  489. using IsValidParsedFormatArg = decltype(IsValidParsedFormatArgTest<T>(nullptr));
  490. TEST_F(ParsedFormatTest, OnlyValidTypesAllowed) {
  491. ASSERT_TRUE(IsValidParsedFormatArg<'c'>::value);
  492. ASSERT_TRUE(IsValidParsedFormatArg<FormatConversionCharSet::d>::value);
  493. ASSERT_TRUE(IsValidParsedFormatArg<absl::FormatConversionCharSet::d |
  494. absl::FormatConversionCharSet::x>::value);
  495. ASSERT_TRUE(
  496. IsValidParsedFormatArg<absl::FormatConversionCharSet::kIntegral>::value);
  497. // This is an easy mistake to make, however, this will reduce to an integer
  498. // which has no meaning, so we need to ensure it doesn't compile.
  499. ASSERT_FALSE(IsValidParsedFormatArg<'x' | 'd'>::value);
  500. // For now, we disallow construction based on ConversionChar (rather than
  501. // CharSet)
  502. ASSERT_FALSE(IsValidParsedFormatArg<absl::FormatConversionChar::d>::value);
  503. }
  504. TEST_F(ParsedFormatTest, ExtendedTyping) {
  505. EXPECT_FALSE(ParsedFormat<FormatConversionCharSet::d>::New(""));
  506. ASSERT_TRUE(ParsedFormat<absl::FormatConversionCharSet::d>::New("%d"));
  507. auto v1 = ParsedFormat<'d', absl::FormatConversionCharSet::s>::New("%d%s");
  508. ASSERT_TRUE(v1);
  509. auto v2 = ParsedFormat<absl::FormatConversionCharSet::d, 's'>::New("%d%s");
  510. ASSERT_TRUE(v2);
  511. auto v3 = ParsedFormat<absl::FormatConversionCharSet::d |
  512. absl::FormatConversionCharSet::s,
  513. 's'>::New("%d%s");
  514. ASSERT_TRUE(v3);
  515. auto v4 = ParsedFormat<absl::FormatConversionCharSet::d |
  516. absl::FormatConversionCharSet::s,
  517. 's'>::New("%s%s");
  518. ASSERT_TRUE(v4);
  519. }
  520. #endif
  521. TEST_F(ParsedFormatTest, UncheckedCorrect) {
  522. auto f =
  523. ExtendedParsedFormat<absl::FormatConversionCharSet::d>::New("ABC%dDEF");
  524. ASSERT_TRUE(f);
  525. EXPECT_EQ("[ABC]{d:1$d}[DEF]", SummarizeParsedFormat(*f));
  526. std::string format = "%sFFF%dZZZ%f";
  527. auto f2 = ExtendedParsedFormat<
  528. absl::FormatConversionCharSet::kString, absl::FormatConversionCharSet::d,
  529. absl::FormatConversionCharSet::kFloating>::New(format);
  530. ASSERT_TRUE(f2);
  531. EXPECT_EQ("{s:1$s}[FFF]{d:2$d}[ZZZ]{f:3$f}", SummarizeParsedFormat(*f2));
  532. f2 = ExtendedParsedFormat<
  533. absl::FormatConversionCharSet::kString, absl::FormatConversionCharSet::d,
  534. absl::FormatConversionCharSet::kFloating>::New("%s %d %f");
  535. ASSERT_TRUE(f2);
  536. EXPECT_EQ("{s:1$s}[ ]{d:2$d}[ ]{f:3$f}", SummarizeParsedFormat(*f2));
  537. auto star =
  538. ExtendedParsedFormat<absl::FormatConversionCharSet::kStar,
  539. absl::FormatConversionCharSet::d>::New("%*d");
  540. ASSERT_TRUE(star);
  541. EXPECT_EQ("{*d:2$1$*d}", SummarizeParsedFormat(*star));
  542. auto dollar =
  543. ExtendedParsedFormat<absl::FormatConversionCharSet::d,
  544. absl::FormatConversionCharSet::s>::New("%2$s %1$d");
  545. ASSERT_TRUE(dollar);
  546. EXPECT_EQ("{2$s:2$s}[ ]{1$d:1$d}", SummarizeParsedFormat(*dollar));
  547. // with reuse
  548. dollar = ExtendedParsedFormat<
  549. absl::FormatConversionCharSet::d,
  550. absl::FormatConversionCharSet::s>::New("%2$s %1$d %1$d");
  551. ASSERT_TRUE(dollar);
  552. EXPECT_EQ("{2$s:2$s}[ ]{1$d:1$d}[ ]{1$d:1$d}",
  553. SummarizeParsedFormat(*dollar));
  554. }
  555. TEST_F(ParsedFormatTest, UncheckedIgnoredArgs) {
  556. EXPECT_FALSE(
  557. (ExtendedParsedFormat<absl::FormatConversionCharSet::d,
  558. absl::FormatConversionCharSet::s>::New("ABC")));
  559. EXPECT_FALSE(
  560. (ExtendedParsedFormat<absl::FormatConversionCharSet::d,
  561. absl::FormatConversionCharSet::s>::New("%dABC")));
  562. EXPECT_FALSE(
  563. (ExtendedParsedFormat<absl::FormatConversionCharSet::d,
  564. absl::FormatConversionCharSet::s>::New("ABC%2$s")));
  565. auto f = ExtendedParsedFormat<
  566. absl::FormatConversionCharSet::d,
  567. absl::FormatConversionCharSet::s>::NewAllowIgnored("ABC");
  568. ASSERT_TRUE(f);
  569. EXPECT_EQ("[ABC]", SummarizeParsedFormat(*f));
  570. f = ExtendedParsedFormat<
  571. absl::FormatConversionCharSet::d,
  572. absl::FormatConversionCharSet::s>::NewAllowIgnored("%dABC");
  573. ASSERT_TRUE(f);
  574. EXPECT_EQ("{d:1$d}[ABC]", SummarizeParsedFormat(*f));
  575. f = ExtendedParsedFormat<
  576. absl::FormatConversionCharSet::d,
  577. absl::FormatConversionCharSet::s>::NewAllowIgnored("ABC%2$s");
  578. ASSERT_TRUE(f);
  579. EXPECT_EQ("[ABC]{2$s:2$s}", SummarizeParsedFormat(*f));
  580. }
  581. TEST_F(ParsedFormatTest, UncheckedMultipleTypes) {
  582. auto dx =
  583. ExtendedParsedFormat<absl::FormatConversionCharSet::d |
  584. absl::FormatConversionCharSet::x>::New("%1$d %1$x");
  585. EXPECT_TRUE(dx);
  586. EXPECT_EQ("{1$d:1$d}[ ]{1$x:1$x}", SummarizeParsedFormat(*dx));
  587. dx = ExtendedParsedFormat<absl::FormatConversionCharSet::d |
  588. absl::FormatConversionCharSet::x>::New("%1$d");
  589. EXPECT_TRUE(dx);
  590. EXPECT_EQ("{1$d:1$d}", SummarizeParsedFormat(*dx));
  591. }
  592. TEST_F(ParsedFormatTest, UncheckedIncorrect) {
  593. EXPECT_FALSE(ExtendedParsedFormat<absl::FormatConversionCharSet::d>::New(""));
  594. EXPECT_FALSE(ExtendedParsedFormat<absl::FormatConversionCharSet::d>::New(
  595. "ABC%dDEF%d"));
  596. std::string format = "%sFFF%dZZZ%f";
  597. EXPECT_FALSE(
  598. (ExtendedParsedFormat<absl::FormatConversionCharSet::s,
  599. absl::FormatConversionCharSet::d,
  600. absl::FormatConversionCharSet::g>::New(format)));
  601. }
  602. TEST_F(ParsedFormatTest, RegressionMixPositional) {
  603. EXPECT_FALSE(
  604. (ExtendedParsedFormat<absl::FormatConversionCharSet::d,
  605. absl::FormatConversionCharSet::o>::New("%1$d %o")));
  606. }
  607. using FormatWrapperTest = ::testing::Test;
  608. // Plain wrapper for StrFormat.
  609. template <typename... Args>
  610. std::string WrappedFormat(const absl::FormatSpec<Args...>& format,
  611. const Args&... args) {
  612. return StrFormat(format, args...);
  613. }
  614. TEST_F(FormatWrapperTest, ConstexprStringFormat) {
  615. EXPECT_EQ(WrappedFormat("%s there", "hello"), "hello there");
  616. }
  617. TEST_F(FormatWrapperTest, ParsedFormat) {
  618. ParsedFormat<'s'> format("%s there");
  619. EXPECT_EQ(WrappedFormat(format, "hello"), "hello there");
  620. }
  621. } // namespace
  622. ABSL_NAMESPACE_END
  623. } // namespace absl
  624. using FormatExtensionTest = ::testing::Test;
  625. struct Point {
  626. friend absl::FormatConvertResult<absl::FormatConversionCharSet::kString |
  627. absl::FormatConversionCharSet::kIntegral>
  628. AbslFormatConvert(const Point& p, const absl::FormatConversionSpec& spec,
  629. absl::FormatSink* s) {
  630. if (spec.conversion_char() == absl::FormatConversionChar::s) {
  631. s->Append(absl::StrCat("x=", p.x, " y=", p.y));
  632. } else {
  633. s->Append(absl::StrCat(p.x, ",", p.y));
  634. }
  635. return {true};
  636. }
  637. int x = 10;
  638. int y = 20;
  639. };
  640. TEST_F(FormatExtensionTest, AbslFormatConvertExample) {
  641. Point p;
  642. EXPECT_EQ(absl::StrFormat("a %s z", p), "a x=10 y=20 z");
  643. EXPECT_EQ(absl::StrFormat("a %d z", p), "a 10,20 z");
  644. // Typed formatting will fail to compile an invalid format.
  645. // StrFormat("%f", p); // Does not compile.
  646. std::string actual;
  647. absl::UntypedFormatSpec f1("%f");
  648. // FormatUntyped will return false for bad character.
  649. EXPECT_FALSE(absl::FormatUntyped(&actual, f1, {absl::FormatArg(p)}));
  650. }
  651. // Some codegen thunks that we can use to easily dump the generated assembly for
  652. // different StrFormat calls.
  653. std::string CodegenAbslStrFormatInt(int i) { // NOLINT
  654. return absl::StrFormat("%d", i);
  655. }
  656. std::string CodegenAbslStrFormatIntStringInt64(int i, const std::string& s,
  657. int64_t i64) { // NOLINT
  658. return absl::StrFormat("%d %s %d", i, s, i64);
  659. }
  660. void CodegenAbslStrAppendFormatInt(std::string* out, int i) { // NOLINT
  661. absl::StrAppendFormat(out, "%d", i);
  662. }
  663. void CodegenAbslStrAppendFormatIntStringInt64(std::string* out, int i,
  664. const std::string& s,
  665. int64_t i64) { // NOLINT
  666. absl::StrAppendFormat(out, "%d %s %d", i, s, i64);
  667. }