Browse Source

gpu: SDL_ClaimWindowForGPUDevice must set an error message on failure

Anonymous Maarten 4 months ago
parent
commit
0370b92d80
3 changed files with 4 additions and 6 deletions
  1. 2 2
      src/gpu/d3d12/SDL_gpu_d3d12.c
  2. 1 2
      src/gpu/metal/SDL_gpu_metal.m
  3. 1 2
      src/gpu/vulkan/SDL_gpu_vulkan.c

+ 2 - 2
src/gpu/d3d12/SDL_gpu_d3d12.c

@@ -6729,7 +6729,7 @@ static bool D3D12_ClaimWindow(
             SET_STRING_ERROR_AND_RETURN("Could not create swapchain, failed to claim window!", false)
         }
     } else {
-        SDL_LogWarn(SDL_LOG_CATEGORY_GPU, "Window already claimed!");
+        SET_STRING_ERROR_AND_RETURN("Window already claimed", false)
         return false;
     }
 }
@@ -6742,7 +6742,7 @@ static void D3D12_ReleaseWindow(
     D3D12WindowData *windowData = D3D12_INTERNAL_FetchWindowData(window);
 
     if (windowData == NULL) {
-        SDL_LogWarn(SDL_LOG_CATEGORY_GPU, "Window already unclaimed!");
+        SET_ERROR("Window already unclaimed!")
         return;
     }
 

+ 1 - 2
src/gpu/metal/SDL_gpu_metal.m

@@ -3624,8 +3624,7 @@ static bool METAL_ClaimWindow(
                 SET_STRING_ERROR_AND_RETURN("Could not create swapchain, failed to claim window", false);
             }
         } else {
-            SDL_LogWarn(SDL_LOG_CATEGORY_GPU, "Window already claimed!");
-            return false;
+            SET_ERROR_AND_RETURN("Window already claimed!", false)
         }
     }
 }

+ 1 - 2
src/gpu/vulkan/SDL_gpu_vulkan.c

@@ -9585,8 +9585,7 @@ static bool VULKAN_ClaimWindow(
             return false;
         }
     } else {
-        SDL_LogWarn(SDL_LOG_CATEGORY_GPU, "Window already claimed!");
-        return false;
+        SET_STRING_ERROR_AND_RETURN("Window already claimed!", false)
     }
 }