Browse Source

RAWINPUT_RegisterNotifications() should return int, for consistency

Sam Lantinga 1 year ago
parent
commit
1903d7b1bf

+ 5 - 6
src/joystick/windows/SDL_rawinputjoystick.c

@@ -2065,13 +2065,13 @@ static void RAWINPUT_JoystickClose(SDL_Joystick *joystick)
     }
 }
 
-SDL_bool RAWINPUT_RegisterNotifications(HWND hWnd)
+int RAWINPUT_RegisterNotifications(HWND hWnd)
 {
     int i;
     RAWINPUTDEVICE rid[SDL_arraysize(subscribed_devices)];
 
     if (!SDL_RAWINPUT_inited) {
-        return SDL_TRUE;
+        return 0;
     }
 
     for (i = 0; i < SDL_arraysize(subscribed_devices); i++) {
@@ -2082,10 +2082,9 @@ SDL_bool RAWINPUT_RegisterNotifications(HWND hWnd)
     }
 
     if (!RegisterRawInputDevices(rid, SDL_arraysize(rid), sizeof(RAWINPUTDEVICE))) {
-        SDL_SetError("Couldn't register for raw input events");
-        return SDL_FALSE;
+        return SDL_SetError("Couldn't register for raw input events");
     }
-    return SDL_TRUE;
+    return 0;
 }
 
 int RAWINPUT_UnregisterNotifications()
@@ -2094,7 +2093,7 @@ int RAWINPUT_UnregisterNotifications()
     RAWINPUTDEVICE rid[SDL_arraysize(subscribed_devices)];
 
     if (!SDL_RAWINPUT_inited) {
-        return SDL_TRUE;
+        return 0;
     }
 
     for (i = 0; i < SDL_arraysize(subscribed_devices); i++) {

+ 1 - 1
src/joystick/windows/SDL_rawinputjoystick_c.h

@@ -28,7 +28,7 @@ extern SDL_bool RAWINPUT_IsEnabled();
 extern SDL_bool RAWINPUT_IsDevicePresent(Uint16 vendor_id, Uint16 product_id, Uint16 version, const char *name);
 
 /* Registers for input events */
-extern SDL_bool RAWINPUT_RegisterNotifications(HWND hWnd);
+extern int RAWINPUT_RegisterNotifications(HWND hWnd);
 extern int RAWINPUT_UnregisterNotifications();
 
 /* Returns 0 if message was handled */