Browse Source

wave: Fixed static analysis warning about dead assignment.

(technically, this function never returns an error at this point, but since
it _does_ have an "uhoh, is this corrupt data?" comment that it ignores, we
should probably make sure we handle error cases in the future.  :)  )
Ryan C. Gordon 5 years ago
parent
commit
2fa33d6f98
1 changed files with 4 additions and 2 deletions
  1. 4 2
      src/audio/SDL_wave.c

+ 4 - 2
src/audio/SDL_wave.c

@@ -1107,9 +1107,11 @@ IMA_ADPCM_Decode(WaveFile *file, Uint8 **audio_buf, Uint32 *audio_len)
 
         /* Initialize decoder with the values from the block header. */
         result = IMA_ADPCM_DecodeBlockHeader(&state);
+        if (result == 0) {
+            /* Decode the block data. It stores the samples directly in the output. */
+            result = IMA_ADPCM_DecodeBlockData(&state);
+        }
 
-        /* Decode the block data. It stores the samples directly in the output. */
-        result = IMA_ADPCM_DecodeBlockData(&state);
         if (result == -1) {
             /* Unexpected end. Stop decoding and return partial data if necessary. */
             if (file->trunchint == TruncVeryStrict || file->trunchint == TruncVeryStrict) {