Parcourir la source

Initialize the padding of aligned allocations to zero

Fixes valgrind uninitialized memory errors when doing SIMD blits
e.g. testautomation --filter surface_testScale
Sam Lantinga il y a 1 mois
Parent
commit
3235a4eb4f
1 fichiers modifiés avec 6 ajouts et 0 suppressions
  1. 6 0
      src/stdlib/SDL_stdlib.c

+ 6 - 0
src/stdlib/SDL_stdlib.c

@@ -533,6 +533,7 @@ void *SDL_aligned_alloc(size_t alignment, size_t size)
 {
     size_t padding;
     Uint8 *result = NULL;
+    size_t requested_size = size;
 
     if (alignment < sizeof(void*)) {
         alignment = sizeof(void*);
@@ -552,6 +553,11 @@ void *SDL_aligned_alloc(size_t alignment, size_t size)
 
             // Store the original pointer right before the returned value
             SDL_memcpy(result - sizeof(original), &original, sizeof(original));
+
+            // Initialize the padding to zero
+            if (padding > 0) {
+                SDL_memset(result + requested_size, 0, padding);
+            }
         }
     }
     return result;