Browse Source

Return true from IsSupportedDevice if it's a device that we _might_ support

This forces an update of the device list so we have the correct state when we check to see whether a device is being handled by HIDAPI
Sam Lantinga 2 years ago
parent
commit
5b4c10fc7b
2 changed files with 26 additions and 11 deletions
  1. 13 5
      src/joystick/hidapi/SDL_hidapi_ps4.c
  2. 13 6
      src/joystick/hidapi/SDL_hidapi_ps5.c

+ 13 - 5
src/joystick/hidapi/SDL_hidapi_ps4.c

@@ -185,11 +185,19 @@ HIDAPI_DriverPS4_IsSupportedDevice(SDL_HIDAPI_Device *device, const char *name,
         return SDL_TRUE;
     }
 
-    if (device && SONY_THIRDPARTY_VENDOR(device->vendor_id) &&
-        (size = ReadFeatureReport(device->dev, k_ePS4FeatureReportIdCapabilities, data, sizeof(data))) == 48 &&
-        data[2] == 0x27) {
-        /* Supported third party controller */
-        return SDL_TRUE;
+    if (SONY_THIRDPARTY_VENDOR(vendor_id)) {
+        if (device) {
+            if ((size = ReadFeatureReport(device->dev, k_ePS4FeatureReportIdCapabilities, data, sizeof(data))) == 48 &&
+                data[2] == 0x27) {
+                /* Supported third party controller */
+                return SDL_TRUE;
+            } else {
+                return SDL_FALSE;
+            }
+        } else {
+            /* Might be supported by this driver, enumerate and find out */
+            return SDL_TRUE;
+        }
     }
 
     return SDL_FALSE;

+ 13 - 6
src/joystick/hidapi/SDL_hidapi_ps5.c

@@ -267,13 +267,20 @@ HIDAPI_DriverPS5_IsSupportedDevice(SDL_HIDAPI_Device *device, const char *name,
         return SDL_TRUE;
     }
 
-    if (device && SONY_THIRDPARTY_VENDOR(device->vendor_id) &&
-        (size = ReadFeatureReport(device->dev, k_EPS5FeatureReportIdCapabilities, data, sizeof(data))) == 48 &&
-        data[2] == 0x28) {
-        /* Supported third party controller */
-        return SDL_TRUE;
+    if (SONY_THIRDPARTY_VENDOR(vendor_id)) {
+        if (device) {
+            if ((size = ReadFeatureReport(device->dev, k_EPS5FeatureReportIdCapabilities, data, sizeof(data))) == 48 &&
+                data[2] == 0x28) {
+                /* Supported third party controller */
+                return SDL_TRUE;
+            } else {
+                return SDL_FALSE;
+            }
+        } else {
+            /* Might be supported by this driver, enumerate and find out */
+            return SDL_TRUE;
+        }
     }
-
     return SDL_FALSE;
 }