Browse Source

Fixed warning C4701: potentially uninitialized local variable 'startup_info' used

Sam Lantinga 7 months ago
parent
commit
718845a33d
1 changed files with 8 additions and 8 deletions
  1. 8 8
      src/process/windows/SDL_windowsprocess.c

+ 8 - 8
src/process/windows/SDL_windowsprocess.c

@@ -216,14 +216,6 @@ bool SDL_SYS_CreateProcessWithProperties(SDL_Process *process, SDL_PropertiesID
     }
     process->internal = data;
 
-    if (!join_arguments(args, &createprocess_cmdline)) {
-        goto done;
-    }
-
-    if (!join_env(envp, &createprocess_env)) {
-        goto done;
-    }
-
     creation_flags = CREATE_UNICODE_ENVIRONMENT;
 
     SDL_zero(startup_info);
@@ -238,6 +230,14 @@ bool SDL_SYS_CreateProcessWithProperties(SDL_Process *process, SDL_PropertiesID
     security_attributes.bInheritHandle = TRUE;
     security_attributes.lpSecurityDescriptor = NULL;
 
+    if (!join_arguments(args, &createprocess_cmdline)) {
+        goto done;
+    }
+
+    if (!join_env(envp, &createprocess_env)) {
+        goto done;
+    }
+
     // Background processes don't have access to the terminal
     // This isn't necessary on Windows, but we keep the same behavior as the POSIX implementation.
     if (process->background) {