Browse Source

Fixed NULL dereference on drop events with no window associated.

(such as when dropping a file onto an app's icon to launch.)

This bug caught by Clang's static analyzer.
Ryan C. Gordon 9 years ago
parent
commit
73680ab374
1 changed files with 5 additions and 1 deletions
  1. 5 1
      src/events/SDL_dropevents.c

+ 5 - 1
src/events/SDL_dropevents.c

@@ -43,7 +43,11 @@ SDL_SendDrop(SDL_Window *window, const SDL_EventType evtype, const char *data)
         if (need_begin) {
             SDL_zero(event);
             event.type = SDL_DROPBEGIN;
-            event.drop.windowID = window->id;
+
+            if (window) {
+                event.drop.windowID = window->id;
+            }
+
             posted = (SDL_PushEvent(&event) > 0);
             if (!posted) {
                 return 0;