Browse Source

Fixed bug 4999 - Palette surface always promoted to alpha (Thanks Cameron Gutman!)

MSVC Static analysis: Incorrect alpha_value check in SDL_render.c
(see also bug 4425)
Sylvain Becker 5 years ago
parent
commit
9a7c2b2246
1 changed files with 1 additions and 1 deletions
  1. 1 1
      src/render/SDL_render.c

+ 1 - 1
src/render/SDL_render.c

@@ -1167,7 +1167,7 @@ SDL_CreateTextureFromSurface(SDL_Renderer * renderer, SDL_Surface * surface)
     if (fmt->palette) {
         for (i = 0; i < fmt->palette->ncolors; i++) {
             Uint8 alpha_value = fmt->palette->colors[i].a;
-            if (alpha_value != 0 || alpha_value != SDL_ALPHA_OPAQUE) {
+            if (alpha_value != 0 && alpha_value != SDL_ALPHA_OPAQUE) {
                 needAlpha = SDL_TRUE;
                 break;
             }