Browse Source

Added note about trigger rumble availability across third-party Xbox One controllers

Sam Lantinga 2 years ago
parent
commit
9d1dbd2ad8
1 changed files with 10 additions and 1 deletions
  1. 10 1
      src/joystick/hidapi/SDL_hidapi_xboxone.c

+ 10 - 1
src/joystick/hidapi/SDL_hidapi_xboxone.c

@@ -153,7 +153,16 @@ static SDL_bool
 ControllerHasTriggerRumble(Uint16 vendor_id, Uint16 product_id)
 {
     /* All the Microsoft Xbox One controllers have trigger rumble */
-    return (vendor_id == USB_VENDOR_MICROSOFT);
+    if (vendor_id == USB_VENDOR_MICROSOFT) {
+        return SDL_TRUE;
+    }
+
+    /* It turns out other controllers a mixed bag as to whether they support
+       trigger rumble or not, and when they do it's often a buzz rather than
+       the vibration of the Microsoft trigger rumble, so for now just pretend
+       that it is not available.
+     */
+    return SDL_FALSE;
 }
 
 static SDL_bool