Browse Source

Fix divide-by-zero when videodata->ime_candpgsize is zero. We're seeing this happen in Dota in the wild.

Drew Bliss 8 years ago
parent
commit
a4dbf56574
1 changed files with 5 additions and 1 deletions
  1. 5 1
      src/video/windows/SDL_windowskeyboard.c

+ 5 - 1
src/video/windows/SDL_windowskeyboard.c

@@ -834,7 +834,11 @@ IME_GetCandidateList(HIMC himc, SDL_VideoData *videodata)
                     videodata->ime_candpgsize = i - page_start;
                 } else {
                     videodata->ime_candpgsize = SDL_min(cand_list->dwPageSize, MAX_CANDLIST);
-                    page_start = (cand_list->dwSelection / videodata->ime_candpgsize) * videodata->ime_candpgsize;
+                    if (videodata->ime_candpgsize > 0) {
+                        page_start = (cand_list->dwSelection / videodata->ime_candpgsize) * videodata->ime_candpgsize;
+                    } else {
+                        page_start = 0;
+                    }
                 }
                 SDL_memset(&videodata->ime_candidates, 0, sizeof(videodata->ime_candidates));
                 for (i = page_start, j = 0; (DWORD)i < cand_list->dwCount && j < (int)videodata->ime_candpgsize; i++, j++) {