Browse Source

Revert "Fixed warning C33010: Unchecked lower bound for enum scancode used as index."

This reverts commit c484140f568ea066c9b7b2c38eb403ac8b6ebfc6.

Fixes clang warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare]
Sam Lantinga 1 year ago
parent
commit
ace385a134
1 changed files with 2 additions and 2 deletions
  1. 2 2
      src/events/SDL_keyboard.c

+ 2 - 2
src/events/SDL_keyboard.c

@@ -754,7 +754,7 @@ void SDL_SetKeymap(int start, const SDL_Keycode *keys, int length, SDL_bool send
 
 void SDL_SetScancodeName(SDL_Scancode scancode, const char *name)
 {
-    if (scancode < 0 || scancode >= SDL_NUM_SCANCODES) {
+    if (scancode >= SDL_NUM_SCANCODES) {
         return;
     }
     SDL_scancode_names[scancode] = name;
@@ -831,7 +831,7 @@ static int SDL_SendKeyboardKeyInternal(Uint64 timestamp, SDL_KeyboardFlags flags
     Uint8 repeat = SDL_FALSE;
     const Uint8 source = flags & KEYBOARD_SOURCE_MASK;
 
-    if (scancode < 0 || scancode == SDL_SCANCODE_UNKNOWN || scancode >= SDL_NUM_SCANCODES) {
+    if (scancode == SDL_SCANCODE_UNKNOWN || scancode >= SDL_NUM_SCANCODES) {
         return 0;
     }