Browse Source

Fixed signed/unsigned warnings

Fixes https://github.com/libsdl-org/SDL/issues/7424
Sam Lantinga 2 years ago
parent
commit
ba87b96cea

+ 1 - 1
src/hidapi/linux/hid.c

@@ -421,7 +421,7 @@ static int get_device_string(hid_device *dev, enum device_string_id key, wchar_t
 					const char *str;
 					const char *key_str = NULL;
 
-					if (key >= 0 && key < DEVICE_STRING_COUNT) {
+					if ((int)key >= 0 && (int)key < DEVICE_STRING_COUNT) {
 						key_str = device_string_names[key];
 					} else {
 						ret = -1;

+ 2 - 2
src/joystick/hidapi/SDL_hidapi_xbox360.c

@@ -113,7 +113,7 @@ static SDL_bool SetSlotLED(SDL_hid_device *dev, Uint8 slot, SDL_bool on)
 
 static void UpdateSlotLED(SDL_DriverXbox360_Context *ctx)
 {
-    if (ctx->player_lights && ctx->player_lights >= 0) {
+    if (ctx->player_lights) {
         SetSlotLED(ctx->device->dev, (ctx->player_index % 4), SDL_TRUE);
     } else {
         SetSlotLED(ctx->device->dev, 0, SDL_FALSE);
@@ -307,7 +307,7 @@ static void HIDAPI_DriverXbox360_HandleStatePacket(SDL_Joystick *joystick, SDL_D
     }
     SDL_SendJoystickAxis(timestamp, joystick, SDL_GAMEPAD_AXIS_RIGHTY, axis);
 
-    SDL_memcpy(ctx->last_state, data, SDL_min(size, sizeof(ctx->last_state)));
+    SDL_memcpy(ctx->last_state, data, SDL_min((size_t)size, sizeof(ctx->last_state)));
 }
 
 static SDL_bool HIDAPI_DriverXbox360_UpdateDevice(SDL_HIDAPI_Device *device)

+ 1 - 1
src/joystick/hidapi/SDL_hidapi_xbox360w.c

@@ -87,7 +87,7 @@ static SDL_bool SetSlotLED(SDL_hid_device *dev, Uint8 slot, SDL_bool on)
 
 static void UpdateSlotLED(SDL_DriverXbox360W_Context *ctx)
 {
-    if (ctx->player_lights && ctx->player_lights >= 0) {
+    if (ctx->player_lights) {
         SetSlotLED(ctx->device->dev, (ctx->player_index % 4), SDL_TRUE);
     } else {
         SetSlotLED(ctx->device->dev, 0, SDL_FALSE);