Browse Source

Fixed bug 3424 - SDL_GameController: Increase k_nMaxReverseEntries

ny00

On Android, the keycodes KEYCODE_BUTTON_1..16 (actual values 188-203) are translated to SDL_Joystick buttons no. 20-35. These are currently ignored in SDL_gamecontroller.c.

The attached patch fixes this, by increasing k_nMaxReverseEntries from 20 to another arbitrary bound of 48.

Side-note: Maybe some log should be emitted in case of going over any such bound?
Sam Lantinga 8 years ago
parent
commit
c2e2565144
1 changed files with 2 additions and 1 deletions
  1. 2 1
      src/joystick/SDL_gamecontroller.c

+ 2 - 1
src/joystick/SDL_gamecontroller.c

@@ -45,7 +45,8 @@ struct _SDL_HatMapping
     Uint8 mask;
 };
 
-#define k_nMaxReverseEntries 20
+/* We need 36 entries for Android (as of SDL v2.0.4) */
+#define k_nMaxReverseEntries 48
 
 /**
  * We are encoding the "HAT" as 0xhm. where h == hat ID and m == mask