Sfoglia il codice sorgente

Fixed bug 5524 - Pass NSString to NSLog()

Hiroyuki Iwatsuki

If you pass the C string directly to NSLog(), it will be garbled with Japanese and probably other language strings, or no log will be output at all.

NSLog("Hello, World!"); // => "Hello, World!"
NSLog("こんにちは、世界!"); // => No output...

Therefore, you need to convert the string to an NSString before passing it to NSLog().

NSString *str = [NSString stringWithUTF8String:"こんにちは、世界!"];
NSLog(@"%@", str); // => "こんにちは、世界!"

Thank you.
Sam Lantinga 4 anni fa
parent
commit
cef198c9cb
2 ha cambiato i file con 8 aggiunte e 2 eliminazioni
  1. 4 1
      src/video/cocoa/SDL_cocoavideo.m
  2. 4 1
      src/video/uikit/SDL_uikitvideo.m

+ 4 - 1
src/video/cocoa/SDL_cocoavideo.m

@@ -260,7 +260,10 @@ Cocoa_CreateImage(SDL_Surface * surface)
 
 void SDL_NSLog(const char *text)
 {
-    NSLog(@"%s", text);
+    @autoreleasepool {
+        NSString *str = [NSString stringWithUTF8String:text];
+        NSLog(@"%@", str);
+    }
 }
 
 #endif /* SDL_VIDEO_DRIVER_COCOA */

+ 4 - 1
src/video/uikit/SDL_uikitvideo.m

@@ -279,7 +279,10 @@ UIKit_ForceUpdateHomeIndicator()
 #if !defined(SDL_VIDEO_DRIVER_COCOA)
 void SDL_NSLog(const char *text)
 {
-    NSLog(@"%s", text);
+    @autoreleasepool {
+        NSString *str = [NSString stringWithUTF8String:text];
+        NSLog(@"%@", str);
+    }
 }
 #endif /* SDL_VIDEO_DRIVER_COCOA */