Browse Source

Fixed potential overflow in surface allocation (thanks Yves!)

Sam Lantinga 7 years ago
parent
commit
d9e1036e0f
1 changed files with 9 additions and 1 deletions
  1. 9 1
      src/video/SDL_surface.c

+ 9 - 1
src/video/SDL_surface.c

@@ -80,7 +80,15 @@ SDL_CreateRGBSurfaceWithFormat(Uint32 flags, int width, int height, int depth,
 
     /* Get the pixels */
     if (surface->w && surface->h) {
-        surface->pixels = SDL_malloc(surface->h * surface->pitch);
+        int size = (surface->h * surface->pitch);
+        if (size < 0 || (size / surface->pitch) != surface->h) {
+            /* Overflow... */
+            SDL_FreeSurface(surface);
+            SDL_OutOfMemory();
+            return NULL;
+        }
+
+        surface->pixels = SDL_malloc(size);
         if (!surface->pixels) {
             SDL_FreeSurface(surface);
             SDL_OutOfMemory();