Parcourir la source

fix integer overflow ub in testautomation_sdltest

Patch originally from https://github.com/libsdl-org/sdl2-compat/pull/241
Erica Z il y a 3 mois
Parent
commit
f804293a27
1 fichiers modifiés avec 2 ajouts et 2 suppressions
  1. 2 2
      test/testautomation_sdltest.c

+ 2 - 2
test/testautomation_sdltest.c

@@ -1074,13 +1074,13 @@ int sdltest_randomIntegerInRange(void *arg)
 
     /* Range with min at integer limit */
     min = long_min;
-    max = long_max + (Sint32)SDLTest_RandomSint16();
+    max = long_min + (Sint32)SDLTest_RandomUint16();
     result = SDLTest_RandomIntegerInRange(min, max);
     SDLTest_AssertPass("Call to SDLTest_RandomIntegerInRange(SINT32_MIN,...)");
     SDLTest_AssertCheck(min <= result && result <= max, "Validated returned value; expected: [%" SDL_PRIs32 ",%" SDL_PRIs32 "], got: %" SDL_PRIs32, min, max, result);
 
     /* Range with max at integer limit */
-    min = long_min - (Sint32)SDLTest_RandomSint16();
+    min = long_max - (Sint32)SDLTest_RandomUint16();
     max = long_max;
     result = SDLTest_RandomIntegerInRange(min, max);
     SDLTest_AssertPass("Call to SDLTest_RandomIntegerInRange(...,SINT32_MAX)");