check_android_jni.py 5.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172
  1. #!/usr/bin/env python
  2. import argparse
  3. import dataclasses
  4. import os
  5. import pathlib
  6. import re
  7. ROOT = pathlib.Path(__file__).resolve().parents[1]
  8. SDL_ANDROID_C = ROOT / "src/core/android/SDL_android.c"
  9. METHOD_SOURCE_PATHS = (
  10. SDL_ANDROID_C,
  11. ROOT / "src/hidapi/android/hid.cpp",
  12. )
  13. JAVA_ROOT = ROOT / "android-project/app/src/main/java"
  14. BASIC_TYPE_SPEC_LUT = {
  15. "char": "C",
  16. "byte": "B",
  17. "short": "S",
  18. "int": "I",
  19. "long": "J",
  20. "float": "F",
  21. "double": "D",
  22. "void": "V",
  23. "boolean": "Z",
  24. "Object": "Ljava/lang/Object;",
  25. "String": "Ljava/lang/String;",
  26. }
  27. @dataclasses.dataclass(frozen=True)
  28. class JniType:
  29. typ: str
  30. array: int
  31. def java_type_to_jni_spec_internal(type_str: str) -> tuple[int, str]:
  32. for basic_type_str, basic_type_spec in BASIC_TYPE_SPEC_LUT.items():
  33. if type_str.startswith(basic_type_str):
  34. return len(basic_type_str), basic_type_spec
  35. raise ValueError(f"Don't know how to convert {repr(type_str)} to its equivalent jni spec")
  36. def java_type_to_jni_spec(type_str: str) -> str:
  37. end, type_spec = java_type_to_jni_spec_internal(type_str)
  38. suffix_str = type_str[end:]
  39. assert(all(c in "[] \t" for c in suffix_str))
  40. suffix_str = "".join(filter(lambda v: v in "[]", suffix_str))
  41. assert len(suffix_str) % 2 == 0
  42. array_spec = "[" * (len(suffix_str) // 2)
  43. return array_spec + type_spec
  44. def java_method_to_jni_spec(ret: str, args: list[str]) -> str:
  45. return "(" + "".join(java_type_to_jni_spec(a) for a in args) +")" + java_type_to_jni_spec(ret)
  46. @dataclasses.dataclass(frozen=True)
  47. class JniMethodBinding:
  48. name: str
  49. spec: str
  50. def collect_jni_bindings_from_c() -> dict[str, set[JniMethodBinding]]:
  51. bindings = {}
  52. sdl_android_text = SDL_ANDROID_C.read_text()
  53. for m in re.finditer(r"""register_methods\((?:[A-Za-z0-9]+),\s*"(?P<class>[a-zA-Z0-9_/]+)",\s*(?P<table>[a-zA-Z0-9_]+),\s*SDL_arraysize\((?P=table)\)\)""", sdl_android_text):
  54. kls = m["class"]
  55. table = m["table"]
  56. methods = set()
  57. in_struct = False
  58. for method_source_path in METHOD_SOURCE_PATHS:
  59. method_source = method_source_path.read_text()
  60. for line in method_source.splitlines(keepends=False):
  61. if re.match(f"(static )?JNINativeMethod {table}" + r"\[([0-9]+)?\] = \{", line):
  62. in_struct = True
  63. continue
  64. if in_struct:
  65. if re.match(r"\};", line):
  66. in_struct = False
  67. break
  68. n = re.match(r"""\s*\{\s*"(?P<method>[a-zA-Z0-9_]+)"\s*,\s*"(?P<spec>[()A-Za-z0-9_/;[]+)"\s*,\s*(\(void\*\))?(HID|SDL)[_A-Z]*_JAVA_[_A-Z]*INTERFACE[_A-Z]*\((?P=method)\)\s*\},?""", line)
  69. assert n, f"'{line}' does not match regex"
  70. methods.add(JniMethodBinding(name=n["method"], spec=n["spec"]))
  71. continue
  72. if methods:
  73. break
  74. if methods:
  75. break
  76. assert methods, f"Could not find methods for {kls} (table={table})"
  77. assert not in_struct
  78. assert kls not in bindings, f"{kls} must be unique in C sources"
  79. bindings[kls] = methods
  80. return bindings
  81. def collect_jni_bindings_from_java() -> dict[str, set[JniMethodBinding]]:
  82. bindings = {}
  83. for root, _, files in os.walk(JAVA_ROOT):
  84. for file in files:
  85. file_path = pathlib.Path(root) / file
  86. java_text = file_path.read_text()
  87. methods = set()
  88. for m in re.finditer(r"(?:(?:public|private)\s+)?(?:static\s+)?native\s+(?P<ret>[A-Za-z0-9_]+)\s+(?P<method>[a-zA-Z0-9_]+)\s*\(\s*(?P<args>[^)]*)\);", java_text):
  89. name = m["method"]
  90. ret = m["ret"]
  91. args = []
  92. args_str = m["args"].strip()
  93. if args_str:
  94. for a_s in args_str.split(","):
  95. atype_str, _ = a_s.strip().rsplit(" ")
  96. args.append(atype_str.strip())
  97. spec = java_method_to_jni_spec(ret=ret, args=args)
  98. methods.add(JniMethodBinding(name=name, spec=spec))
  99. if methods:
  100. relative_java_path = file_path.relative_to(JAVA_ROOT)
  101. relative_java_path_without_suffix = relative_java_path.with_suffix("")
  102. kls = "/".join(relative_java_path_without_suffix.parts)
  103. assert kls not in bindings, f"{kls} must be unique in JAVA sources"
  104. bindings[kls] = methods
  105. return bindings
  106. def print_error(*args):
  107. print("ERROR:", *args)
  108. def main():
  109. parser = argparse.ArgumentParser(allow_abbrev=False, description="Verify Android JNI bindings")
  110. args = parser.parse_args()
  111. bindings_from_c = collect_jni_bindings_from_c()
  112. bindings_from_java = collect_jni_bindings_from_java()
  113. all_ok = bindings_from_c == bindings_from_java
  114. if all_ok:
  115. print("OK")
  116. else:
  117. print("NOT OK")
  118. kls_c = set(bindings_from_c.keys())
  119. kls_java = set(bindings_from_java.keys())
  120. if kls_c != kls_java:
  121. only_c = kls_c - kls_java
  122. for c in only_c:
  123. print_error(f"Missing class in JAVA sources: {c}")
  124. only_java = kls_java - kls_c
  125. for c in only_java:
  126. print_error(f"Missing class in C sources: {c}")
  127. klasses = kls_c.union(kls_java)
  128. for kls in klasses:
  129. m_c = bindings_from_c.get(kls)
  130. m_j = bindings_from_java.get(kls)
  131. if m_c and m_j and m_c != m_j:
  132. m_only_c = m_c - m_j
  133. for c in m_only_c:
  134. print_error(f"{kls}: Binding only in C source: {c.name} {c.spec}")
  135. m_only_j = m_j - m_c
  136. for c in m_only_j:
  137. print_error(f"{kls}: Binding only in JAVA source: {c.name} {c.spec}")
  138. return 0 if all_ok else 1
  139. if __name__ == "__main__":
  140. raise SystemExit(main())