lenn/LearnOpenGL
1
0
Fork 0
mirror of https://github.com/JoeyDeVries/LearnOpenGL.git synced 2026-01-30 20:13:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix infinite loop error w/ unsigned ints used on decrementing for counters.

Browse Source
This commit is contained in:
Joey de Vries
2020-04-22 12:58:38 +02:00
parent 7452f38392
commit a8499a2668
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/6.pbr/1.1.lighting/lighting.cpp
View File

@@ -289,7 +289,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);

2
src/6.pbr/1.2.lighting_textured/lighting_textured.cpp
View File

@@ -300,7 +300,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);

2
src/6.pbr/2.1.1.ibl_irradiance_conversion/ibl_irradiance_conversion.cpp
View File

@@ -405,7 +405,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);

2
src/6.pbr/2.1.2.ibl_irradiance/ibl_irradiance.cpp
View File

@@ -445,7 +445,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);

2
src/6.pbr/2.2.1.ibl_specular/ibl_specular.cpp
View File

@@ -543,7 +543,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);

2
src/6.pbr/2.2.2.ibl_specular_textured/ibl_specular_textured.cpp
View File

@@ -643,7 +643,7 @@ void renderSphere()
} }
else else
{ {
for (unsigned int x = X_SEGMENTS; x >= 0; --x) for (int x = X_SEGMENTS; x >= 0; --x)
{ {
indices.push_back((y + 1) * (X_SEGMENTS + 1) + x); indices.push_back((y + 1) * (X_SEGMENTS + 1) + x);
indices.push_back(y * (X_SEGMENTS + 1) + x); indices.push_back(y * (X_SEGMENTS + 1) + x);