Commit Graph

130 Commits

Author SHA1 Message Date
keith2018
1a70c3efad fix shader file names 2018-04-12 10:33:41 +08:00
Joey de Vries
d0fc384f29 Merge pull request #104 from d3BugErr/master
Another take on PBR tutorials missing rows and columns
2018-04-10 15:51:48 +02:00
Erik
686797546a Update lighting_textured.cpp
Real fix for missing rows and columns.
2018-04-10 16:47:52 +03:00
Erik
ac1784f29b Update lighting.cpp
Real fix for missing rows and columns.
2018-04-10 16:47:20 +03:00
Joey de Vries
75648e81f6 Merge pull request #103 from d3BugErr/master
Tutorial PBR 1.1 sphere grid construction fix
2018-04-10 12:56:43 +02:00
d3BugErr
3eaf086897 Spheres model matrix generation fix
Fix of integer division resulting in some spheres being rendered at same position.
Removed redundant float cast as all operands are being promoted to double anyways.
2018-04-10 13:07:43 +03:00
Erik
e511ca603d Revert "Spheres model matrix generation fix"
This reverts commit d702e0c6bf.
2018-04-10 12:39:42 +03:00
d3BugErr
d702e0c6bf Spheres model matrix generation fix
Fix of integer division resulting in some spheres being rendered at same position.
Removed redundant float cast as all operands are being promoted to double anyways.
2018-04-10 11:23:09 +03:00
Joey de Vries
3309ae604b Fix skybox order. 2018-01-22 19:11:11 +01:00
Joey de Vries
f9913d5aa8 Merge branch 'master' of https://github.com/JoeyDeVries/LearnOpenGL 2018-01-16 08:51:04 +01:00
Joey de Vries
3b605521fb Fix geometry shader normal homogenous coordinate, and use std::string instead of aString for model loading. 2018-01-16 08:50:57 +01:00
Joey de Vries
56dfb32615 Merge pull request #93 from stfx/patch-4
Fix another graphical error showing a black box
2017-11-26 22:35:32 +01:00
stfx
b4982b4611 Fix another graphical error showing a black box
Is needed in addition to #92 to fix all graphical errors. Happens due to divide by 0 when `roughness = 0.0` and `NdotH = 1.0`.

Also use max to clamp similar fix for specular calculation instead of addition to fix the formula in normal cases
2017-11-26 22:10:59 +01:00
stfx
c217609890 Fix rare graphical error showing a black box
This may happen at certain hard to replicate viewing angles.

Theoretically clamp 0,1 should also be faster since SAT (saturate) is a free operation on output however since saturate only exists on HLSL we are at the mercy of the GLSL compiler to replace clamp 0,1 with SAT. Source: http://www.humus.name/Articles/Persson_LowLevelThinking.pdf#page=22
2017-11-26 20:03:44 +01:00
Joey de Vries
ea32df7b91 Merge branch 'master' of https://github.com/JoeyDeVries/LearnOpenGL 2017-10-21 10:07:27 +02:00
Joey de Vries
d4b675bbcd Set max specular IBL reflection mip level to 4.0 to match the number of generated mips. 2017-10-21 10:07:19 +02:00
dotlive
8fef6cdd3e fix shader file’s variable name dismatched with source file’s. 2017-10-19 07:30:33 +08:00
Joey de Vries
3a04c6f9f4 Fix reflection mip level constant on PBR textured scene. 2017-09-26 19:11:01 +02:00
Joey de Vries
673fe1e89f Merge branch 'master' of https://github.com/JoeyDeVries/LearnOpenGL 2017-09-21 08:35:18 +02:00
Joey de Vries
2e0035a8d4 fix: use radians instead of degrees for camera zoom. 2017-09-21 08:35:13 +02:00
stfx
33ee64327f Fix typo 2017-08-19 16:59:35 +02:00
stfx
dc4dee3f82 Fix Bloom in rare cases
BloomColor was not initialized with a value and therefore could incorrectly bloom non-bright pixels.

Maybe... since the issue randomly started to happen on my system (i5-4570, GTX 760) without any hardware or software changes I know of. Even older versions of my program then suddenly had this problem and this was the only working fix which was mentioned in the comments section on the tutorial: https://learnopengl.com/#!Advanced-Lighting/Bloom#comment-2693931521)
2017-08-19 16:57:49 +02:00
Joey de Vries
c6b404915d Merge branch 'master' of https://github.com/JoeyDeVries/LearnOpenGL 2017-07-24 20:08:58 +02:00
Joey de Vries
b379c0fe74 Additional statements to clarify usage of FileSystem namespace in Textures tutorial. 2017-07-24 20:08:53 +02:00
Shivpratap Chauhan
b5848894eb Add glfw hint for GLFW_OPENGL_FORWARD_COMPAT for more samples to let it
work on osx
2017-07-12 21:33:07 +05:30
Shivpratap Chauhan
2d16ef0fe2 GLFW hint GLFW_OPENGL_FORWARD_COMPAT is must on osx to create glfw
window successfully
2017-07-12 17:06:00 +05:30
Joey de Vries
effe69f83d Merge branch 'master' of https://github.com/JoeyDeVries/LearnOpenGL 2017-07-10 08:37:02 +02:00
Joey de Vries
103b4f6358 Coordinate system code fix. 2017-07-10 08:36:52 +02:00
Erik
c4c5fea218 Changed MSVC std::sqrtf call to simple std::sqrt - causes compile failure on mingw toolchain, as no such fucntion is present. 2017-07-04 13:40:47 +03:00
Charles Zhang
e7382fdfb0 fix texture1 uniform name & two shader variables 2017-06-29 18:37:08 +08:00
Joey de Vries
905be9ce52 Use appropriate texture fs name on setting uniform. 2017-06-29 08:38:48 +02:00
Charles Zhang
ecc7e7ca92 Variable name does not match with that in frag shader 2017-06-29 14:32:27 +08:00
Joey de Vries
4bd8846929 Merge pull request #61 from amesgames/master
Fixed stencil testing sample to actually set the uniform matrices on …
2017-06-29 08:10:14 +02:00
Matthew Taylor
4a94fbf2bf Add commented out code to allow window creation on OSX 2017-06-18 01:53:16 +01:00
Matthew Taylor
120c8c8c11 Fix OSX errors and warnings 2017-06-18 00:39:07 +01:00
Joey de Vries
8c45cab498 Final PBR adjustments on code/content-rework. 2017-06-02 23:03:46 +02:00
Joey de Vries
5eddf64303 Code and content re-work: advanced lighting. 2017-06-02 22:53:53 +02:00
Joey de Vries
f844f7c541 Code and content re-work: advanced OpenGL and advanced lighting. 2017-06-01 22:04:34 +02:00
Joey de Vries
49d8d895ae Updated source code to reflect content changes (code re-work): advanced OpenGL and model-loading. 2017-05-31 23:12:15 +02:00
Joey de Vries
70b789d3b9 Code re-work with content: model-loading. 2017-05-31 19:02:05 +02:00
Joey de Vries
e2e36d6ff8 Code re-work and content update: lighting. 2017-05-30 22:17:40 +02:00
Joey de Vries
320db41e89 Code re-work and content update: lighting. 2017-05-30 19:23:56 +02:00
Joey de Vries
18e5fdb443 Code/content re-work: getting started. 2017-05-29 23:47:28 +02:00
Joey de Vries
79e22d716e Content/code update: coordinate systems. 2017-05-29 22:43:07 +02:00
Joey de Vries
28eb2bbf62 Updated code changes to reflect content updates. 2017-05-29 21:04:33 +02:00
Joey de Vries
5846428705 Getting started content code-rework updates. 2017-05-29 20:36:10 +02:00
Joey de Vries
13ad6528cd Final updates on PBR tutorials w/ updated code. 2017-05-28 08:52:26 +02:00
Joey de Vries
a398a343a4 PBR Shader fix to code standard. 2017-05-26 15:49:29 +02:00
Joey de Vries
701f4fe608 Fix build errors w/ long path name. 2017-05-26 15:07:44 +02:00
Joey de Vries
ecd23d4de0 All PBR tuts updated. 2017-05-26 15:00:56 +02:00